Skip to content

[SPARKR][DOC] regexp_extract should doc that it returns empty string when match fails #14934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARKR][DOC] regexp_extract should doc that it returns empty string when match fails #14934

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion R/pkg/R/functions.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2876,7 +2876,8 @@ setMethod("randn", signature(seed = "numeric"),

#' regexp_extract
#'
#' Extract a specific(idx) group identified by a java regex, from the specified string column.
#' Extract a specific \code{idx} group identified by a Java regex, from the specified string column.
Copy link
Contributor

@shivaram shivaram Sep 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment: It looks like idx was removed in the comment change in #14525 -- I'm not sure if it matters, but we could either keep it consistent with the Scala/Python doc or keep the idx if you think it helps.

Copy link
Member Author

@felixcheung felixcheung Sep 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that - I thought @param idx a group index isn't super descriptive on what it is

Copy link
Contributor

@shivaram shivaram Sep 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool sounds good.

#' If the regex did not match, or the specified group did not match, an empty string is returned.
#'
#' @param x a string Column.
#' @param pattern a regular expression.
Expand Down