Skip to content

[SPARK-16588][SQL] Missed API fix for a function name mismatched between FunctionRegistry and functions.scala #14236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-16588][SQL] Missed API fix for a function name mismatched between FunctionRegistry and functions.scala #14236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ import org.apache.spark.mllib.linalg.MatrixImplicits._
import org.apache.spark.mllib.linalg.VectorImplicits._
import org.apache.spark.rdd.RDD
import org.apache.spark.sql.{DataFrame, Dataset, Row, SparkSession}
import org.apache.spark.sql.functions.{col, monotonicallyIncreasingId, udf}
import org.apache.spark.sql.functions.{col, monotonically_increasing_id, udf}
import org.apache.spark.sql.types.StructType


Expand Down Expand Up @@ -888,7 +888,7 @@ object LDA extends DefaultParamsReadable[LDA] {
dataset: Dataset[_],
featuresCol: String): RDD[(Long, OldVector)] = {
dataset
.withColumn("docId", monotonicallyIncreasingId())
.withColumn("docId", monotonically_increasing_id())
.select("docId", featuresCol)
.rdd
.map { case Row(docId: Long, features: Vector) =>
Expand Down
3 changes: 3 additions & 0 deletions sql/core/src/main/scala/org/apache/spark/sql/functions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -977,7 +977,10 @@ object functions {
*
* @group normal_funcs
* @since 1.4.0
* @deprecated As of 2.0.0, replaced by `monotonically_increasing_id`. This will be removed in
* Spark 2.1.
*/
@deprecated("Use monotonically_increasing_id. This will be removed in Spark 2.1.", "2.0.0")
Copy link
Contributor

@rxin rxin Jul 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably don't want to remove it in 2.1. can you just say "Use monotonically_increasing_id()"

def monotonicallyIncreasingId(): Column = monotonically_increasing_id()

/**
Expand Down