[SPARK-16588][SQL] Missed API fix for a function name mismatched between FunctionRegistry and functions.scala #14236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y and functions.scala
Member
Author
|
FYI, there is one more usage in ColumnExpressionSuite.scala#L517 which is dedicated test for this one. |
Member
Author
|
cc @rxin |
|
Test build #62427 has finished for PR 14236 at commit
|
| * @deprecated As of 2.0.0, replaced by `monotonically_increasing_id`. This will be removed in | ||
| * Spark 2.1. | ||
| */ | ||
| @deprecated("Use monotonically_increasing_id. This will be removed in Spark 2.1.", "2.0.0") |
Contributor
There was a problem hiding this comment.
we probably don't want to remove it in 2.1. can you just say "Use monotonically_increasing_id()"
Contributor
|
Since it is a small change I will just push a commit myself. Thanks for noticing it. |
Member
Author
|
@rxin Sure, Thank you very much. |
asfgit
pushed a commit
that referenced
this pull request
Jul 18, 2016
This patch deprecates monotonicallyIncreasingId in Scala/Java, as done in Python. This patch was originally written by HyukjinKwon. Closes #14236. (cherry picked from commit 480c870) Signed-off-by: Reynold Xin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It seems the function
monotonicallyIncreasingIdwas missed in https://issues.apache.org/jira/browse/SPARK-10621The registered name is monotonically_increasing_id but monotonicallyIncreasingId was still not deprecated and removed.
So, this was also missed in https://issues.apache.org/jira/browse/SPARK-12600 (removing deprecated APIs).
How was this patch tested?
N/A