Skip to content

Conversation

@jerryshao
Copy link
Contributor

What changes were proposed in this pull request?

Free memory size displayed in the log is wrong (used memory), fix to make it correct. Backported to 1.6.

How was this patch tested?

N/A

@jerryshao jerryshao changed the title [Minor][Core][backport] Fix display wrong free memory size in the log [Minor][Core][1.6-backport] Fix display wrong free memory size in the log Jul 4, 2016
@srowen
Copy link
Member

srowen commented Jul 4, 2016

Just for reference, what PR or JIRA is this backporting?

@jerryshao
Copy link
Contributor Author

jerryshao commented Jul 4, 2016

#13804

No JIRA, just minor fix. CC @lw-lin

@SparkQA
Copy link

SparkQA commented Jul 4, 2016

Test build #61712 has finished for PR 14043 at commit a519540.

  • This patch fails from timeout after a configured wait of 250m.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jerryshao
Copy link
Contributor Author

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jul 4, 2016

Test build #61725 has finished for PR 14043 at commit a519540.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Jul 5, 2016

LGTM pending tests.

@SparkQA
Copy link

SparkQA commented Jul 5, 2016

Test build #3163 has finished for PR 14043 at commit a519540.

  • This patch fails build dependency tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jul 5, 2016

Jenkins retest this please

@SparkQA
Copy link

SparkQA commented Jul 5, 2016

Test build #61793 has finished for PR 14043 at commit a519540.

  • This patch fails build dependency tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jerryshao
Copy link
Contributor Author

Looks like there're some problem with build:

exec: curl -s -L https://www.apache.org/dyn/closer.lua?action=download&filename=/maven/maven-3/3.3.3/binaries/apache-maven-3.3.3-bin.tar.gz

gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now
exec: curl -s -L http://downloads.typesafe.com/zinc/0.3.5.3/zinc-0.3.5.3.tgz
exec: curl -s -L http://downloads.typesafe.com/scala/2.10.5/scala-2.10.5.tgz
Using `mvn` from path: /home/jenkins/workspace/NewSparkPullRequestBuilder/build/apache-maven-3.3.3/bin/mvn
build/mvn: line 152: /home/jenkins/workspace/NewSparkPullRequestBuilder/build/apache-maven-3.3.3/bin/mvn: No such file or directory
Error while getting version string from Maven:

Maven tarball cannot be downloaded or uncompressed.

@jerryshao
Copy link
Contributor Author

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jul 6, 2016

Test build #61802 has finished for PR 14043 at commit a519540.

  • This patch fails build dependency tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jerryshao
Copy link
Contributor Author

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jul 6, 2016

Test build #61831 has finished for PR 14043 at commit a519540.

  • This patch fails build dependency tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jerryshao
Copy link
Contributor Author

Looks like this url (https://www.apache.org/dyn/closer.lua?action=download&filename=/maven/maven-3/3.3.3/binaries/apache-maven-3.3.3-bin.tar.gz) to download maven is 404 not found.

Tried with different urls, only 3.3.9 can be found, there's no 3.3.3 maven binaries.

Is it a building issue for branch 1.6? Checked the master branch building log looks like it uses maven 3.3.9 on the Jenkins server.

@srowen
Copy link
Member

srowen commented Jul 6, 2016

Oh, I imagine they finally cleaned out the old 3.3.x binaries from the mirrors. I think it's best to update branch-1.6 to refer to Maven 3.3.9 in the build. It was done for 2.0/master in b844048 but we don't necessarily want to apply that whole patch.

See #14066

@jerryshao
Copy link
Contributor Author

Thanks @srowen for pointing out this pr, I'm not sure how many changes need to be back-ported into 1.6, can you please file a patch to 1.6 branch to upgrade maven? Seems currently it blocks 1.6 build. Thanks a lot.

@srowen
Copy link
Member

srowen commented Jul 6, 2016

Jenkins retest this please

@SparkQA
Copy link

SparkQA commented Jul 6, 2016

Test build #61847 has finished for PR 14043 at commit a519540.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jul 6, 2016

Jenkins retest this please

@SparkQA
Copy link

SparkQA commented Jul 6, 2016

Test build #61849 has finished for PR 14043 at commit a519540.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 6, 2016

Test build #61848 has finished for PR 14043 at commit a519540.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jul 6, 2016

Merged to 1.6

asfgit pushed a commit that referenced this pull request Jul 6, 2016
… log

## What changes were proposed in this pull request?

Free memory size displayed in the log is wrong (used memory), fix to make it correct. Backported to 1.6.

## How was this patch tested?

N/A

Author: jerryshao <[email protected]>

Closes #14043 from jerryshao/memory-log-fix-1.6-backport.
@rxin
Copy link
Contributor

rxin commented Jul 6, 2016

@jerryshao can you close the pull request now it's merged? thanks.

@jerryshao
Copy link
Contributor Author

Thanks @srowen and @rxin for your review, I will close it.

@jerryshao jerryshao closed this Jul 7, 2016
zzcclp pushed a commit to zzcclp/spark that referenced this pull request Jul 7, 2016
… log

## What changes were proposed in this pull request?

Free memory size displayed in the log is wrong (used memory), fix to make it correct. Backported to 1.6.

## How was this patch tested?

N/A

Author: jerryshao <[email protected]>

Closes apache#14043 from jerryshao/memory-log-fix-1.6-backport.

(cherry picked from commit 2588776)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants