[Minor][Core] Fix display wrong free memory size in the log #13804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryshao
changed the title
jerryshao
changed the title
|
Test build #60921 has finished for PR 13804 at commit
|
Contributor
Author
|
Jenkins, retest this please. |
Member
|
Certainly looks more correct |
|
Test build #60931 has finished for PR 13804 at commit
|
Contributor
Author
|
Any further comments @srowen , from my understanding it worth fixing. |
asfgit
pushed a commit
that referenced
this pull request
Jun 27, 2016
## What changes were proposed in this pull request? Free memory size displayed in the log is wrong (used memory), fix to make it correct. ## How was this patch tested? N/A Author: jerryshao <[email protected]> Closes #13804 from jerryshao/memory-log-fix. (cherry picked from commit 52d4fe0) Signed-off-by: Sean Owen <[email protected]>
Member
|
Merged to master/2.0 |
Contributor
Author
|
Thanks a lot @srowen . |
Contributor
|
hi @jerryshao, let's also back-port this into 1.6.x (MemoryStore.scala#L395) maybe? |
Contributor
Author
|
OK, let me do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Free memory size displayed in the log is wrong (used memory), fix to make it correct.
How was this patch tested?
N/A