[SPARK-16127][ML][PYPSARK] Audit @Since annotations related to ml.linalg #13840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
June 21, 2016 15:36
Contributor
Author
|
@mengxr this PR also reverts the updates to concrete classes for Let me know what you think. |
|
Test build #61020 has finished for PR 13840 at commit
|
Contributor
Author
|
jenkins retest this please |
|
Test build #61022 has finished for PR 13840 at commit
|
Contributor
|
LGTM. Merged into master and branch-2.0. Thanks for testing class compatibility! |
asfgit
pushed a commit
that referenced
this pull request
Jun 22, 2016
[SPARK-14615](https://issues.apache.org/jira/browse/SPARK-14615) and #12627 changed `spark.ml` pipelines to use the new `ml.linalg` classes for `Vector`/`Matrix`. Some `Since` annotations for public methods/vals have not been updated accordingly to be `2.0.0`. This PR updates them. ## How was this patch tested? Existing unit tests. Author: Nick Pentreath <[email protected]> Closes #13840 from MLnick/SPARK-16127-ml-linalg-since. (cherry picked from commit 18faa58) Signed-off-by: Xiangrui Meng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPARK-14615 and #12627 changed
spark.mlpipelines to use the newml.linalgclasses forVector/Matrix. Some@Sinceannotations for public methods/vals have not been updated accordingly to be2.0.0. This PR updates them.How was this patch tested?
Existing unit tests.