-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-10258][DOC][ML] Add @Since annotations to ml.feature #13641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3c8be11 to
bb43722
Compare
|
Test build #60400 has finished for PR 13641 at commit
|
|
Test build #60401 has finished for PR 13641 at commit
|
|
Test build #60402 has finished for PR 13641 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not due to this PR, but here seems like a typo since MaxAbsScaler was added after 1.6.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And in L174 and L177 should also be @Since("2.0.0").
|
@MLnick I found you did not add |
9978afa to
86ab82b
Compare
|
Test build #60694 has finished for PR 13641 at commit
|
|
@yanboliang thanks - updated. I also added annotations on overridden methods Let me know if I missed anything! |
|
Test build #60699 has finished for PR 13641 at commit
|
|
Test build #60700 has finished for PR 13641 at commit
|
| * the vector to multiply with input vectors | ||
| * @group param | ||
| */ | ||
| @Since("1.4.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This uses the new Vector. So ideally it is since 2.0.0. I'm not sure about whether we should change the class since version to 2.0 as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, and also yeah technically all unary transformers over Vector should probably be since 2.0.0. Will update
|
@mengxr @yanboliang I went ahead and bumped all |
|
Test build #60842 has finished for PR 13641 at commit
|
This PR adds missing `Since` annotations to `ml.feature` package. Closes #8505. ## How was this patch tested? Existing tests. Author: Nick Pentreath <[email protected]> Closes #13641 from MLnick/add-since-annotations. (cherry picked from commit 37494a1) Signed-off-by: Xiangrui Meng <[email protected]>
|
@mengxr I thought more about the I thought the concrete classes would be binary incompatible but I don't actually think that is the case - and I just tested this (master against commit immediately prior to e2efe05) and apart from I've created SPARK-16127 to track further annotations that need updating related to new |
This PR adds missing
@Sinceannotations toml.featurepackage.Closes #8505.
How was this patch tested?
Existing tests.