[SPARK-15827][BUILD] Publish Spark's forked sbt-pom-reader to Maven Central #13564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #60189 has finished for PR 13564 at commit
|
JoshRosen
changed the title
project/plugins.sbt
Outdated
| // In the long run, we should try to merge our patch upstream and switch to an upstream version of | ||
| // the plugin; this is tracked at SPARK-14401. | ||
|
|
||
| resolvers += "Spark fork of sbt-pom-reader" at "https://oss.sonatype.org/content/repositories/orgspark-project-1124" |
Contributor
Author
There was a problem hiding this comment.
No, if we decide that the bits that I published here look okay then I'll push to central and remove this resolver.
Contributor
Author
There was a problem hiding this comment.
Done. Let's wait for it to hit Central.
Member
|
Thanks for doing this. It will definitely save time, and some CPU cycles(energy) for all the first time builds. |
|
Test build #60216 has finished for PR 13564 at commit
|
JoshRosen
changed the title
Contributor
Author
|
This is now sync'd to Maven Central and has passed tests, so I'm going to merge it into master, branch-2.0, and branch-1.6. |
asfgit
pushed a commit
that referenced
this pull request
Jun 9, 2016
…entral Spark's SBT build currently uses a fork of the sbt-pom-reader plugin but depends on that fork via a SBT subproject which is cloned from https://github.com/scrapcodes/sbt-pom-reader/tree/ignore_artifact_id. This unnecessarily slows down the initial build on fresh machines and is also risky because it risks a build breakage in case that GitHub repository ever changes or is deleted. In order to address these issues, I have published a pre-built binary of our forked sbt-pom-reader plugin to Maven Central under the `org.spark-project` namespace and have updated Spark's build to use that artifact. This published artifact was built from https://github.com/JoshRosen/sbt-pom-reader/tree/v1.0.0-spark, which contains the contents of ScrapCodes's branch plus an additional patch to configure the build for artifact publication. /cc srowen ScrapCodes for review. Author: Josh Rosen <[email protected]> Closes #13564 from JoshRosen/use-published-fork-of-pom-reader. (cherry picked from commit f74b777) Signed-off-by: Josh Rosen <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Jun 9, 2016
…entral Spark's SBT build currently uses a fork of the sbt-pom-reader plugin but depends on that fork via a SBT subproject which is cloned from https://github.com/scrapcodes/sbt-pom-reader/tree/ignore_artifact_id. This unnecessarily slows down the initial build on fresh machines and is also risky because it risks a build breakage in case that GitHub repository ever changes or is deleted. In order to address these issues, I have published a pre-built binary of our forked sbt-pom-reader plugin to Maven Central under the `org.spark-project` namespace and have updated Spark's build to use that artifact. This published artifact was built from https://github.com/JoshRosen/sbt-pom-reader/tree/v1.0.0-spark, which contains the contents of ScrapCodes's branch plus an additional patch to configure the build for artifact publication. /cc srowen ScrapCodes for review. Author: Josh Rosen <[email protected]> Closes #13564 from JoshRosen/use-published-fork-of-pom-reader. (cherry picked from commit f74b777) Signed-off-by: Josh Rosen <[email protected]>
zjffdu
pushed a commit
to zjffdu/spark
that referenced
this pull request
Jun 10, 2016
…entral Spark's SBT build currently uses a fork of the sbt-pom-reader plugin but depends on that fork via a SBT subproject which is cloned from https://github.com/scrapcodes/sbt-pom-reader/tree/ignore_artifact_id. This unnecessarily slows down the initial build on fresh machines and is also risky because it risks a build breakage in case that GitHub repository ever changes or is deleted. In order to address these issues, I have published a pre-built binary of our forked sbt-pom-reader plugin to Maven Central under the `org.spark-project` namespace and have updated Spark's build to use that artifact. This published artifact was built from https://github.com/JoshRosen/sbt-pom-reader/tree/v1.0.0-spark, which contains the contents of ScrapCodes's branch plus an additional patch to configure the build for artifact publication. /cc srowen ScrapCodes for review. Author: Josh Rosen <[email protected]> Closes apache#13564 from JoshRosen/use-published-fork-of-pom-reader.
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
Jun 12, 2016
…entral Spark's SBT build currently uses a fork of the sbt-pom-reader plugin but depends on that fork via a SBT subproject which is cloned from https://github.com/scrapcodes/sbt-pom-reader/tree/ignore_artifact_id. This unnecessarily slows down the initial build on fresh machines and is also risky because it risks a build breakage in case that GitHub repository ever changes or is deleted. In order to address these issues, I have published a pre-built binary of our forked sbt-pom-reader plugin to Maven Central under the `org.spark-project` namespace and have updated Spark's build to use that artifact. This published artifact was built from https://github.com/JoshRosen/sbt-pom-reader/tree/v1.0.0-spark, which contains the contents of ScrapCodes's branch plus an additional patch to configure the build for artifact publication. /cc srowen ScrapCodes for review. Author: Josh Rosen <[email protected]> Closes apache#13564 from JoshRosen/use-published-fork-of-pom-reader. (cherry picked from commit f74b777) Signed-off-by: Josh Rosen <[email protected]> (cherry picked from commit 739d992)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spark's SBT build currently uses a fork of the sbt-pom-reader plugin but depends on that fork via a SBT subproject which is cloned from https://github.com/scrapcodes/sbt-pom-reader/tree/ignore_artifact_id. This unnecessarily slows down the initial build on fresh machines and is also risky because it risks a build breakage in case that GitHub repository ever changes or is deleted.
In order to address these issues, I have published a pre-built binary of our forked sbt-pom-reader plugin to Maven Central under the
org.spark-projectnamespace and have updated Spark's build to use that artifact. This published artifact was built from https://github.com/JoshRosen/sbt-pom-reader/tree/v1.0.0-spark, which contains the contents of @ScrapCodes's branch plus an additional patch to configure the build for artifact publication./cc @srowen @ScrapCodes for review.