Skip to content

Commit 07a914c

Browse files
committed
[SPARK-15827][BUILD] Publish Spark's forked sbt-pom-reader to Maven Central
Spark's SBT build currently uses a fork of the sbt-pom-reader plugin but depends on that fork via a SBT subproject which is cloned from https://github.com/scrapcodes/sbt-pom-reader/tree/ignore_artifact_id. This unnecessarily slows down the initial build on fresh machines and is also risky because it risks a build breakage in case that GitHub repository ever changes or is deleted. In order to address these issues, I have published a pre-built binary of our forked sbt-pom-reader plugin to Maven Central under the `org.spark-project` namespace and have updated Spark's build to use that artifact. This published artifact was built from https://github.com/JoshRosen/sbt-pom-reader/tree/v1.0.0-spark, which contains the contents of ScrapCodes's branch plus an additional patch to configure the build for artifact publication. /cc srowen ScrapCodes for review. Author: Josh Rosen <[email protected]> Closes #13564 from JoshRosen/use-published-fork-of-pom-reader. (cherry picked from commit f74b777) Signed-off-by: Josh Rosen <[email protected]>
1 parent 10f7599 commit 07a914c

File tree

2 files changed

+9
-28
lines changed

2 files changed

+9
-28
lines changed

project/plugins.sbt

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,3 +21,12 @@ libraryDependencies += "org.ow2.asm" % "asm" % "5.0.3"
2121
libraryDependencies += "org.ow2.asm" % "asm-commons" % "5.0.3"
2222

2323
addSbtPlugin("com.simplytyped" % "sbt-antlr4" % "0.7.11")
24+
25+
// Spark uses a custom fork of the sbt-pom-reader plugin which contains a patch to fix issues
26+
// related to test-jar dependencies (https://github.com/sbt/sbt-pom-reader/pull/14). The source for
27+
// this fork is published at https://github.com/JoshRosen/sbt-pom-reader/tree/v1.0.0-spark
28+
// and corresponds to commit b160317fcb0b9d1009635a7c5aa05d0f3be61936 in that repository.
29+
// In the long run, we should try to merge our patch upstream and switch to an upstream version of
30+
// the plugin; this is tracked at SPARK-14401.
31+
32+
addSbtPlugin("org.spark-project" % "sbt-pom-reader" % "1.0.0-spark")

project/project/SparkPluginBuild.scala

Lines changed: 0 additions & 28 deletions
This file was deleted.

0 commit comments

Comments
 (0)