[Minor] [ML] [PySpark] ml.evaluation Scala and Python API sync #13195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| # Because we will maximize evaluation value (ref: `CrossValidator`), | ||
| # when we evaluate a metric that is needed to minimize (e.g., `"rmse"`, `"mse"`, `"mae"`), | ||
| # we take and output the negative of this metric. |
Contributor
Author
There was a problem hiding this comment.
In Spark 1.4, we negated some metrics from RegressionEvaluator since CrossValidator always maximized metrics. This was fixed in 1.5, #12377 updated the Scala docs, this PR updates the Python docs.
|
Test build #58861 has finished for PR 13195 at commit
|
|
Test build #58862 has finished for PR 13195 at commit
|
|
Test build #58863 has finished for PR 13195 at commit
|
Contributor
Author
Contributor
|
LGTM. Merged into master and branch-2.0. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
May 20, 2016
## What changes were proposed in this pull request? ```ml.evaluation``` Scala and Python API sync. ## How was this patch tested? Only API docs change, no new tests. Author: Yanbo Liang <[email protected]> Closes #13195 from yanboliang/evaluation-doc. (cherry picked from commit 6643677) Signed-off-by: Xiangrui Meng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ml.evaluationScala and Python API sync.How was this patch tested?
Only API docs change, no new tests.