Skip to content

Conversation

@jkbradley
Copy link
Member

What changes were proposed in this pull request?

In Spark 1.4, we negated some metrics from RegressionEvaluator since CrossValidator always maximized metrics. This was fixed in 1.5, but the docs were not updated. This PR updates the docs.

How was this patch tested?

no tests

@SparkQA
Copy link

SparkQA commented Apr 14, 2016

Test build #55777 has finished for PR 12377 at commit 5d05fdd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@MLnick
Copy link
Contributor

MLnick commented Apr 14, 2016

LGTM

@jkbradley
Copy link
Member Author

@MLnick thanks! I'll merge this with master and backport to the 1.5, 1.6 docs too.

asfgit pushed a commit that referenced this pull request Apr 14, 2016
## What changes were proposed in this pull request?

In Spark 1.4, we negated some metrics from RegressionEvaluator since CrossValidator always maximized metrics. This was fixed in 1.5, but the docs were not updated. This PR updates the docs.

## How was this patch tested?

no tests

Author: Joseph K. Bradley <[email protected]>

Closes #12377 from jkbradley/regeval-doc.

(cherry picked from commit bf65c87)
Signed-off-by: Joseph K. Bradley <[email protected]>
asfgit pushed a commit that referenced this pull request Apr 14, 2016
## What changes were proposed in this pull request?

In Spark 1.4, we negated some metrics from RegressionEvaluator since CrossValidator always maximized metrics. This was fixed in 1.5, but the docs were not updated. This PR updates the docs.

## How was this patch tested?

no tests

Author: Joseph K. Bradley <[email protected]>

Closes #12377 from jkbradley/regeval-doc.

(cherry picked from commit bf65c87)
Signed-off-by: Joseph K. Bradley <[email protected]>
@asfgit asfgit closed this in bf65c87 Apr 14, 2016
@jkbradley jkbradley deleted the regeval-doc branch April 14, 2016 20:48
zzcclp pushed a commit to zzcclp/spark that referenced this pull request Apr 19, 2016
## What changes were proposed in this pull request?

In Spark 1.4, we negated some metrics from RegressionEvaluator since CrossValidator always maximized metrics. This was fixed in 1.5, but the docs were not updated. This PR updates the docs.

## How was this patch tested?

no tests

Author: Joseph K. Bradley <[email protected]>

Closes apache#12377 from jkbradley/regeval-doc.

(cherry picked from commit bf65c87)
Signed-off-by: Joseph K. Bradley <[email protected]>
(cherry picked from commit 93c9a63)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants