[SPARK-14819] [SQL] Improve SET / SET -v command #12583
Conversation
|
Test build #56582 has finished for PR 12583 at commit
|
|
You might need to rebase this in a bit because i'm refactoring all of these quite heavily for Spark 2.0. |
| } | ||
|
|
||
| test("set / set -v") { | ||
| checkExistence(sql("set"), true, "env:", "system:") |
There was a problem hiding this comment.
can we add a test case that checks the value of SPARK_TESTING?
There was a problem hiding this comment.
SPARK_TESTING is not in sys.env nor sys.props while running the test cases. Any suggestions to add the test cases for that?
There was a problem hiding this comment.
Found out that current test cases SQLQuerySuite and HiveQuerySuite have intensive test coverage for SET command.
|
Test build #56585 has finished for PR 12583 at commit
|
|
Test build #56603 has finished for PR 12583 at commit
|
|
Test build #56636 has finished for PR 12583 at commit
|
|
Test build #56651 has finished for PR 12583 at commit
|
|
Test build #56653 has finished for PR 12583 at commit
|
|
@bomeng while you are at this, do you mind implementing https://issues.apache.org/jira/browse/SPARK-14806 together? Should be pretty trivial. Thanks. |
|
Test build #56688 has finished for PR 12583 at commit
|
|
Hi, @bomeng . |
| (keyValueOutput, runFunc) | ||
|
|
||
| // Queries all properties along with their default values and docs that are defined in the | ||
| // SQLConf of the sqlContext. |
There was a problem hiding this comment.
We should update the comment regarding the system environment properties.
| (keyValueOutput, runFunc) | ||
|
|
||
| // (In Hive, "SET" returns all changed properties while "SET -v" returns all properties.) | ||
| // Queries all key-value pairs that are set in the SQLConf of the sqlContext. |
| override def run(sqlContext: SQLContext): Seq[Row] = runFunc(sqlContext) | ||
|
|
||
| /** | ||
| * get the system environment properties as a sequence |
There was a problem hiding this comment.
Nit: "get" -> "Gets", "as a sequence" -> "as a sequence of rows".
|
Hmm. This PR seems to be stale. Actually, what I wanted was a sorted result of |
|
I made another #16579 for |
|
@dongjoon-hyun, then, do you mind if I ask if this PR is not useful in favour of #16579? |
|
Hi, @bomeng , do you have something to refresh here? |
6 participants
What changes were proposed in this pull request?
Currently
SETandSET -vcommands are similar to HiveSETcommand except the following difference:SETandSET -v, in addition to the Hive related properties, it will also list all the system properties and environment properties, which is very useful in some cases.This JIRA is trying to make the current
SETcommand more consistent to Hive output.How was this patch tested?
Current test cases SQLQuerySuite and HiveQuerySuite should have enough test coverage.