Skip to content

Commit 2a077bd

Browse files
author
bomeng
committed
improve the codes and fix test failure
1 parent 392327a commit 2a077bd

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -232,11 +232,10 @@ case class SetCommand(kv: Option[(String, Option[String])]) extends RunnableComm
232232
* @return the sequence of the rows containing the key/value pair of system properties
233233
*/
234234
private def getEnvList(withDoc: Boolean) = {
235-
import scala.collection.JavaConverters._
236-
System.getenv().asScala.toSeq.sortBy(_._1).map {
235+
sys.env.toSeq.sortBy(_._1).map {
237236
case (k, v) => if (withDoc) Row(s"env:$k", v, "") else Row(s"env:$k", v)
238237
} ++
239-
System.getProperties.asScala.toSeq.sortBy(_._1).map {
238+
sys.props.toSeq.sortBy(_._1).map {
240239
case (k, v) => if (withDoc) Row(s"system:$k", v, "") else Row(s"system:$k", v)
241240
}
242241
}

sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1145,12 +1145,15 @@ class HiveQuerySuite extends HiveComparisonTest with BeforeAndAfter {
11451145
}.toSet
11461146
conf.clear()
11471147

1148-
val expectedConfs = conf.getAllDefinedConfs.toSet
1148+
val expectedConfs = conf.getAllDefinedConfs.toSet ++
1149+
sys.env.map { case (k, v) => (s"env:$k", v, "") }.toSet ++
1150+
sys.props.map { case (k, v) => (s"system:$k", v, "") }.toSet
11491151
assertResult(expectedConfs)(collectResults(sql("SET -v")))
11501152

11511153
// "SET" itself returns all config variables currently specified in SQLConf.
11521154
// TODO: Should we be listing the default here always? probably...
1153-
assert(sql("SET").collect().size === TestHiveContext.overrideConfs.size)
1155+
val additionalSize = sys.env.size + sys.props.size
1156+
assert(sql("SET").collect().size === TestHiveContext.overrideConfs.size + additionalSize)
11541157

11551158
val defaults = collectResults(sql("SET"))
11561159
assertResult(Set(testKey -> testVal)) {

0 commit comments

Comments
 (0)