Skip to content

SPARK-2804: Remove scalalogging-slf4j dependency #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

SPARK-2804: Remove scalalogging-slf4j dependency #1208

wants to merge 1 commit into from

Conversation

@witgo
Copy link
Contributor

@witgo witgo commented Jun 25, 2014

No description provided.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 25, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 25, 2014

Merged build started.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 25, 2014

Merged build finished.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 25, 2014

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16103/

@rxin
Copy link
Contributor

rxin commented Jun 25, 2014

To be honest, my scar from the incident (deprecating Scala 2.10 support before Scala 2.11 was even released) hasn't fully recovered. Do we gain anything by moving onto this logging API? There is a tiny teeny performance boost, but I don't think we log any hot code path in spark-core.

@witgo
Copy link
Contributor Author

witgo commented Jun 25, 2014

The main benefit is unified log Interface. Now the code using scala-logging-slf4j and slf4j-api at the same time

@SparkQA
Copy link

SparkQA commented Jul 11, 2014

QA tests have started for PR 1208. This patch DID NOT merge cleanly!
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16549/consoleFull

@SparkQA
Copy link

SparkQA commented Jul 11, 2014

QA results for PR 1208:
- This patch FAILED unit tests.

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16549/consoleFull

@SparkQA
Copy link

SparkQA commented Jul 11, 2014

QA tests have started for PR 1208. This patch DID NOT merge cleanly!
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16550/consoleFull

@witgo witgo closed this Jul 11, 2014
@SparkQA
Copy link

SparkQA commented Jul 11, 2014

QA tests have started for PR 1208. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16551/consoleFull

@witgo witgo deleted the SPARK-1470 branch July 11, 2014 04:03
@witgo witgo reopened this Jul 11, 2014
@witgo witgo closed this Jul 11, 2014
@witgo witgo restored the SPARK-1470 branch July 11, 2014 04:07
@witgo witgo deleted the SPARK-1470 branch July 11, 2014 04:11
@witgo witgo restored the SPARK-1470 branch July 11, 2014 04:11
@SparkQA
Copy link

SparkQA commented Jul 11, 2014

QA results for PR 1208:
- This patch FAILED unit tests.

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16550/consoleFull

@SparkQA
Copy link

SparkQA commented Jul 11, 2014

QA results for PR 1208:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16551/consoleFull

@witgo witgo deleted the SPARK-1470 branch July 11, 2014 05:45
@srowen srowen mentioned this pull request Jul 11, 2014
Closed
@witgo witgo restored the SPARK-1470 branch July 15, 2014 13:50
@witgo witgo changed the title SPARK-1470: Use the scala-logging wrapper instead of the directly sfl4j api SPARK-1470: Remove scalalogging-slf4j dependency Aug 2, 2014
@witgo witgo changed the title SPARK-1470: Remove scalalogging-slf4j dependency [WIP][SPARK-1470]: Remove scalalogging-slf4j dependency Aug 2, 2014
@witgo witgo reopened this Aug 2, 2014
@SparkQA
Copy link

SparkQA commented Aug 2, 2014

QA tests have started for PR 1208. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17761/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 2, 2014

QA tests have started for PR 1208. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17764/consoleFull

@witgo
Copy link
Contributor Author

witgo commented Aug 2, 2014

@pwendell @marmbrus How to test the performance impact of the PR?

@SparkQA
Copy link

SparkQA commented Aug 2, 2014

QA results for PR 1208:
- This patch FAILED unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17761/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 2, 2014

QA results for PR 1208:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17764/consoleFull

@asfgit asfgit closed this in 4c47711 Aug 2, 2014
@pwendell
Copy link
Contributor

pwendell commented Aug 2, 2014

Okay - I've merged this into master and 1.1 with three changes:

  1. This patch converted a warning to a debug (https://github.com/apache/spark/pull/1208/files#diff-6b519cd0a9dc5b0ee9caab7712d252e9L238), I reverted that change.
  2. In this patch, TestHive.scala still used the old format (log.info), so I switched it to use the standard Spark format that includes guards (e.g. logInfo).
  3. I updated the title to reflect a new JIRA that more correctly describes the current approach.

4c47711

asfgit pushed a commit that referenced this pull request Aug 2, 2014
@witgo @pwendell
SPARK-2804: Remove scalalogging-slf4j dependency
7924d72 
This also Closes #1701.

Author: GuoQiang Li <[email protected]>

Closes #1208 from witgo/SPARK-1470 and squashes the following commits:

422646b [GuoQiang Li] Remove scalalogging-slf4j dependency
@witgo witgo deleted the SPARK-1470 branch August 3, 2014 01:20
@witgo witgo changed the title [WIP][SPARK-1470]: Remove scalalogging-slf4j dependency SPARK-2804: Remove scalalogging-slf4j dependency Aug 3, 2014
@witgo
Copy link
Contributor Author

witgo commented Aug 3, 2014

Cool thanks

@mengxr mengxr mentioned this pull request Aug 3, 2014
Merged
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@witgo @conviva-zz
SPARK-2804: Remove scalalogging-slf4j dependency
2979cf4 
This also Closes apache#1701.

Author: GuoQiang Li <[email protected]>

Closes apache#1208 from witgo/SPARK-1470 and squashes the following commits:

422646b [GuoQiang Li] Remove scalalogging-slf4j dependency
wangyum pushed a commit that referenced this pull request May 26, 2023
[CARMEL-6518] Record temp view usage in workload analysis (#1208)
deb3e82 
* [CARMEL-6518] Record temp view usage in workload analysis

* record temp view

* fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@witgo @AmplabJenkins @rxin @SparkQA @pwendell