Skip to content

[SPARK-1812] upgrade dependency to scala-logging 2.1.2 #1701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-1812] upgrade dependency to scala-logging 2.1.2 #1701

wants to merge 1 commit into from

Conversation

@avati
Copy link
Contributor

@avati avati commented Jul 31, 2014

Scala 2.11 packages not available for the current version (1.0.1)

Signed-off-by: Anand Avati [email protected]

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 31, 2014

Can one of the admins verify this patch?

@avati avati changed the title SPARK-1812: upgrade dependency to scala-logging 2.1.2 [SPARK-1812] upgrade dependency to scala-logging 2.1.2 Jul 31, 2014
@avati avati changed the title [SPARK-1812] upgrade dependency to scala-logging 2.1.2 [SPARK-1812] [SPARK-1842] upgrade dependency to scala-logging 2.1.2 Jul 31, 2014
@avati avati changed the title [SPARK-1812] [SPARK-1842] upgrade dependency to scala-logging 2.1.2 [SPARK-1812] upgrade dependency to scala-logging 2.1.2 Aug 1, 2014
@ScrapCodes
Copy link
Member

ScrapCodes commented Aug 1, 2014

Jenkins, test this please.

ScrapCodes
ScrapCodes reviewed Aug 1, 2014
View reviewed changes
sql/core/pom.xml
Copy link
Member

@ScrapCodes ScrapCodes Aug 1, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why we need the second artifact ?

Copy link
Contributor Author

@avati avati Aug 1, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scalalogging-slf4j-1.0.1 seems to be split into scala-logging-{slf4j,api} for 2.1.2. Previously scalalogging was missing in sql/core pom.xml (usually not a problem unless you do mvn compile within the module)

@ScrapCodes
Copy link
Member

ScrapCodes commented Aug 1, 2014

@pwendell Jenkins does not listen to my commands, Can you command it ?

@ScrapCodes
Copy link
Member

ScrapCodes commented Aug 1, 2014

LGTM, if jenkins build passes. It would be good to merge this with #940.

@avati avati mentioned this pull request Aug 1, 2014
Closed
@mengxr
Copy link
Contributor

mengxr commented Aug 1, 2014

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Aug 1, 2014

QA tests have started for PR 1701. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17676/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 1, 2014

QA results for PR 1701:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17676/consoleFull

@asfgit asfgit closed this in 4c47711 Aug 2, 2014
asfgit pushed a commit that referenced this pull request Aug 2, 2014
@witgo @pwendell
SPARK-2804: Remove scalalogging-slf4j dependency
7924d72 
This also Closes #1701.

Author: GuoQiang Li <[email protected]>

Closes #1208 from witgo/SPARK-1470 and squashes the following commits:

422646b [GuoQiang Li] Remove scalalogging-slf4j dependency
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@witgo @conviva-zz
SPARK-2804: Remove scalalogging-slf4j dependency
2979cf4 
This also Closes apache#1701.

Author: GuoQiang Li <[email protected]>

Closes apache#1208 from witgo/SPARK-1470 and squashes the following commits:

422646b [GuoQiang Li] Remove scalalogging-slf4j dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@avati @AmplabJenkins @ScrapCodes @mengxr @SparkQA