[SPARK-13522][Core]Executor should kill itself when it's unable to heartbeat to driver more than N times #11401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #52078 has finished for PR 11401 at commit
|
Member
Author
|
cc @andrewor14 |
|
Test build #52088 has finished for PR 11401 at commit
|
Contributor
|
m |
asfgit
pushed a commit
that referenced
this pull request
Feb 29, 2016
## What changes were proposed in this pull request? Just fixed the log place introduced by #11401 ## How was this patch tested? unit tests. Author: Shixiong Zhu <[email protected]> Closes #11432 from zsxwing/SPARK-13522-follow-up.
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
…eartbeat to driver more than N times ## What changes were proposed in this pull request? Sometimes, network disconnection event won't be triggered for other potential race conditions that we may not have thought of, then the executor will keep sending heartbeats to driver and won't exit. This PR adds a new configuration `spark.executor.heartbeat.maxFailures` to kill Executor when it's unable to heartbeat to the driver more than `spark.executor.heartbeat.maxFailures` times. ## How was this patch tested? unit tests Author: Shixiong Zhu <[email protected]> Closes apache#11401 from zsxwing/SPARK-13522.
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request? Just fixed the log place introduced by apache#11401 ## How was this patch tested? unit tests. Author: Shixiong Zhu <[email protected]> Closes apache#11432 from zsxwing/SPARK-13522-follow-up.
asfgit
pushed a commit
that referenced
this pull request
May 11, 2016
…eartbeat to driver more than N times ## What changes were proposed in this pull request? Sometimes, network disconnection event won't be triggered for other potential race conditions that we may not have thought of, then the executor will keep sending heartbeats to driver and won't exit. This PR adds a new configuration `spark.executor.heartbeat.maxFailures` to kill Executor when it's unable to heartbeat to the driver more than `spark.executor.heartbeat.maxFailures` times. ## How was this patch tested? unit tests Author: Shixiong Zhu <[email protected]> Closes #11401 from zsxwing/SPARK-13522.
asfgit
pushed a commit
that referenced
this pull request
May 11, 2016
## What changes were proposed in this pull request? Just fixed the log place introduced by #11401 ## How was this patch tested? unit tests. Author: Shixiong Zhu <[email protected]> Closes #11432 from zsxwing/SPARK-13522-follow-up.
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
May 12, 2016
…eartbeat to driver more than N times ## What changes were proposed in this pull request? Sometimes, network disconnection event won't be triggered for other potential race conditions that we may not have thought of, then the executor will keep sending heartbeats to driver and won't exit. This PR adds a new configuration `spark.executor.heartbeat.maxFailures` to kill Executor when it's unable to heartbeat to the driver more than `spark.executor.heartbeat.maxFailures` times. ## How was this patch tested? unit tests Author: Shixiong Zhu <[email protected]> Closes apache#11401 from zsxwing/SPARK-13522. (cherry picked from commit 86bf93e)
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
May 12, 2016
## What changes were proposed in this pull request? Just fixed the log place introduced by apache#11401 ## How was this patch tested? unit tests. Author: Shixiong Zhu <[email protected]> Closes apache#11432 from zsxwing/SPARK-13522-follow-up. (cherry picked from commit ced71d3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Sometimes, network disconnection event won't be triggered for other potential race conditions that we may not have thought of, then the executor will keep sending heartbeats to driver and won't exit.
This PR adds a new configuration
spark.executor.heartbeat.maxFailuresto kill Executor when it's unable to heartbeat to the driver more thanspark.executor.heartbeat.maxFailurestimes.How was this patch tested?
unit tests