[SPARK-2061] Made splits deprecated in JavaRDDLike #1062
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Contributor
There was a problem hiding this comment.
I'm not sure how well this shows up in JavaDoc. Can you test it out?
We might need to add the java @deprecated, and then explain it has been deprecated since 1.0.1. (it is not 0.9.2).
Contributor
There was a problem hiding this comment.
@rxin actually I don't think we should deprecate things inside of bug fix releases (people shouldn't get compile warnings for upgrading to a fix release). So this should be deprecated since 1.1.0.
Contributor
|
@anantasty could you do the second part of this JIRA? It's in your description but it looks like you didn't do it: "We should also go through all cases where other API's (e.g. Python) call splits and we should change those to use the newer API." |
Contributor
Author
|
@pwendell I can certianly do that. |
AtlasPilotPuppy
changed the title
Contributor
There was a problem hiding this comment.
I fixed this when merging.
pdeyhim
pushed a commit
to pdeyhim/spark-1
that referenced
this pull request
Jun 25, 2014
The jira for the issue can be found at: https://issues.apache.org/jira/browse/SPARK-2061 Most of spark has used over to consistently using `partitions` instead of `splits`. We should do likewise and add a `partitions` method to JavaRDDLike and have `splits` just call that. We should also go through all cases where other API's (e.g. Python) call `splits` and we should change those to use the newer API. Author: Anant <[email protected]> Closes apache#1062 from anantasty/SPARK-2061 and squashes the following commits: b83ce6b [Anant] Fixed syntax issue 21f9210 [Anant] Fixed version number in deprecation string 9315b76 [Anant] made related changes to use partitions in python api 8c62dd1 [Anant] Made splits deprecated in JavaRDDLike
xiliu82
pushed a commit
to xiliu82/spark
that referenced
this pull request
Sep 4, 2014
The jira for the issue can be found at: https://issues.apache.org/jira/browse/SPARK-2061 Most of spark has used over to consistently using `partitions` instead of `splits`. We should do likewise and add a `partitions` method to JavaRDDLike and have `splits` just call that. We should also go through all cases where other API's (e.g. Python) call `splits` and we should change those to use the newer API. Author: Anant <[email protected]> Closes apache#1062 from anantasty/SPARK-2061 and squashes the following commits: b83ce6b [Anant] Fixed syntax issue 21f9210 [Anant] Fixed version number in deprecation string 9315b76 [Anant] made related changes to use partitions in python api 8c62dd1 [Anant] Made splits deprecated in JavaRDDLike
flyrain
pushed a commit
to flyrain/spark
that referenced
this pull request
Sep 21, 2021
wangyum
pushed a commit
that referenced
this pull request
May 26, 2023
udaynpusa
pushed a commit
to mapr/spark
that referenced
this pull request
Jan 30, 2024
- add 'proxy' authentication handler
mapr-devops
pushed a commit
to mapr/spark
that referenced
this pull request
May 8, 2025
- add 'proxy' authentication handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jira for the issue can be found at: https://issues.apache.org/jira/browse/SPARK-2061
Most of spark has used over to consistently using
partitionsinstead ofsplits. We should do likewise and add apartitionsmethod to JavaRDDLike and havesplitsjust call that. We should also go through all cases where other API's (e.g. Python) callsplitsand we should change those to use the newer API.