Skip to content

[SPARK-2061] Made splits deprecated in JavaRDDLike #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[SPARK-2061] Made splits deprecated in JavaRDDLike #1062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c62dd1
Made splits deprecated in JavaRDDLike
AtlasPilotPuppy Jun 11, 2014
9315b76
made related changes to use partitions in python api
AtlasPilotPuppy Jun 13, 2014
21f9210
Fixed version number in deprecation string
AtlasPilotPuppy Jun 13, 2014
b83ce6b
Fixed syntax issue
AtlasPilotPuppy Jun 13, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion core/src/main/scala/org/apache/spark/api/java/JavaRDDLike.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,11 @@ trait JavaRDDLike[T, This <: JavaRDDLike[T, This]] extends Serializable {

def rdd: RDD[T]

/** Set of partitions in this RDD. */
@deprecated("Use partitions instead.", "1.0.1")
Copy link
Contributor

@pwendell pwendell Jun 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 1.1.0

Copy link
Contributor

@pwendell pwendell Jun 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed this when merging.

def splits: JList[Partition] = new java.util.ArrayList(rdd.partitions.toSeq)

/** Set of partitions in this RDD. */
def partitions: JList[Partition] = new java.util.ArrayList(rdd.partitions.toSeq)

/** The [[org.apache.spark.SparkContext]] that this RDD was created on. */
def context: SparkContext = rdd.context
Expand Down
2 changes: 1 addition & 1 deletion python/pyspark/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ def runJob(self, rdd, partitionFunc, partitions = None, allowLocal = False):
[0, 1, 16, 25]
"""
if partitions == None:
partitions = range(rdd._jrdd.splits().size())
partitions = range(rdd._jrdd.partitions().size())
javaPartitions = ListConverter().convert(partitions, self._gateway._gateway_client)

# Implementation note: This is implemented as a mapPartitions followed
Expand Down
2 changes: 1 addition & 1 deletion python/pyspark/rdd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,7 +855,7 @@ def take(self, num):
[91, 92, 93]
"""
items = []
totalParts = self._jrdd.splits().size()
totalParts = self._jrdd.partitions().size()
partsScanned = 0

while len(items) < num and partsScanned < totalParts:
Expand Down