Skip to content

[SPARK-12450][MLLib] Un-persist broadcasted variables in KMeans #10415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-12450][MLLib] Un-persist broadcasted variables in KMeans #10415

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4245cee
SPARK-12450 Un-persist broadcasted variables in KMeans
rnowling Dec 21, 2015
974ef4e
Add blank lines to fix style issues
rnowling Jan 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,8 @@ class KMeans private (
contribs.iterator
}.reduceByKey(mergeContribs).collectAsMap()

bcActiveCenters.unpersist(blocking = false)

// Update the cluster centers and costs for each active run
for ((run, i) <- activeRuns.zipWithIndex) {
var changed = false
Expand Down Expand Up @@ -324,7 +326,10 @@ class KMeans private (
s0
}
)

bcNewCenters.unpersist(blocking = false)
Copy link
Contributor

@thunterdb thunterdb Jan 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit: add new lines around this line

preCosts.unpersist(blocking = false)

val chosen = data.zip(costs).mapPartitionsWithIndex { (index, pointsWithCosts) =>
val rand = new XORShiftRandom(seed ^ (step << 16) ^ index)
pointsWithCosts.flatMap { case (p, c) =>
Expand Down Expand Up @@ -353,6 +358,9 @@ class KMeans private (
((r, KMeans.findClosest(bcCenters.value(r), p)._1), 1.0)
}
}.reduceByKey(_ + _).collectAsMap()

bcCenters.unpersist(blocking = false)
Copy link
Contributor

@thunterdb thunterdb Jan 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit: add new lines around this line


val finalCenters = (0 until runs).par.map { r =>
val myCenters = centers(r).toArray
val myWeights = (0 until myCenters.length).map(i => weightMap.getOrElse((r, i), 0.0)).toArray
Expand Down