Skip to content

[SPARK-12450][MLLib] Un-persist broadcasted variables in KMeans #10415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-12450][MLLib] Un-persist broadcasted variables in KMeans #10415

wants to merge 2 commits into from

Conversation

@rnowling
Copy link
Contributor

@rnowling rnowling commented Dec 21, 2015

SPARK-12450 . Un-persist broadcasted variables in KMeans.

@rnowling rnowling changed the title SPARK-12450 Un-persist broadcasted variables in KMeans [SPARK-12450][MLLib] Un-persist broadcasted variables in KMeans Dec 21, 2015
@SparkQA
Copy link

SparkQA commented Dec 21, 2015

Test build #48116 has finished for PR 10415 at commit 4245cee.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

thunterdb
thunterdb reviewed Jan 5, 2016
View reviewed changes
mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala Outdated
Copy link
Contributor

@thunterdb thunterdb Jan 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit: add new lines around this line

@thunterdb
Copy link
Contributor

thunterdb commented Jan 5, 2016

@rnowling thanks for fixing this, I just have some style comments.

@rnowling
Copy link
Contributor Author

rnowling commented Jan 5, 2016

@thunterdb Thanks for the review! Let me know if these changes are what you had in mind.

@SparkQA
Copy link

SparkQA commented Jan 5, 2016

Test build #48728 has finished for PR 10415 at commit 974ef4e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jan 5, 2016

LGTM

@jkbradley
Copy link
Member

jkbradley commented Jan 5, 2016

LGTM too
I'll merge this with master, branch-1.6 and branch-1.5

asfgit pushed a commit that referenced this pull request Jan 5, 2016
@rnowling @jkbradley
[SPARK-12450][MLLIB] Un-persist broadcasted variables in KMeans
0afad66 
SPARK-12450 . Un-persist broadcasted variables in KMeans.

Author: RJ Nowling <[email protected]>

Closes #10415 from rnowling/spark-12450.

(cherry picked from commit 78015a8)
Signed-off-by: Joseph K. Bradley <[email protected]>
asfgit pushed a commit that referenced this pull request Jan 5, 2016
@rnowling @jkbradley
[SPARK-12450][MLLIB] Un-persist broadcasted variables in KMeans
4c176d9 
SPARK-12450 . Un-persist broadcasted variables in KMeans.

Author: RJ Nowling <[email protected]>

Closes #10415 from rnowling/spark-12450.

(cherry picked from commit 78015a8)
Signed-off-by: Joseph K. Bradley <[email protected]>
@asfgit asfgit closed this in 78015a8 Jan 5, 2016
@rnowling
Copy link
Contributor Author

rnowling commented Jan 6, 2016

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rnowling @SparkQA @thunterdb @srowen @jkbradley