feat: enforce LIST_PAGINATION_ENABLED #2401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snazy
reviewed
Aug 20, 2025
| return PageTokenUtil.decodePageRequest(serializedPageToken, requestedPageSize); | ||
| @Nullable String serializedPageToken, | ||
| @Nullable Integer requestedPageSize, | ||
| Supplier<Boolean> shouldDecodeToken) { |
Member
There was a problem hiding this comment.
Why is this a Supplier? None of the call sites is really "dynamic".
Contributor
Author
There was a problem hiding this comment.
It is not called when the token is null, so it avoids touching the config look up in most cases... I'm fine with an unconditional config lookup too. What is preferable from your POV?
Member
There was a problem hiding this comment.
Hm, neither getResolvedCatalogEntity nor getConfig are really simple.
Mind making this at least a Predicate?
Contributor
Author
There was a problem hiding this comment.
Predicate is a one-argument function, but here we just need to have a deferred getter for a simple boolean 🤔
Updated to BooleanSupplier. WDYT?
The enforcement of the LIST_PAGINATION_ENABLED flag was missed in apache#1938. This change make the flag effective as discussed in apache#2296. Note: this causes a change in the default Polaris behaviour (no pagination by default) with respect to the previous state of `main`. However, there is no behaviour change with respect to 1.0.0 or 1.0.1 as previous releases did not have apache#1938.
snazy
approved these changes
Aug 20, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
eric-maynard
approved these changes
Aug 20, 2025
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
dimas-b
added a commit
to dimas-b/polaris
that referenced
this pull request
Aug 20, 2025
Correct method args (follow-up to apache#2401)
dimas-b
added a commit
that referenced
this pull request
Aug 20, 2025
Correct method args (follow-up to #2401)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enforcement of the LIST_PAGINATION_ENABLED flag was missed in #1938. This change make the flag effective as discussed in #2296.
Note: this causes a change in the default Polaris behaviour (no pagination by default) with respect to the previous state of
main. However, there is no behaviour change with respect to 1.0.0 or 1.0.1 as previous releases did not have #1938.