Skip to content

Conversation

@pingtimeout
Copy link
Contributor

@pingtimeout pingtimeout commented Aug 20, 2025

Command to list all commits that were added to main and that are not already included in 1.1.0:

git log --cherry-pick --right-only --format="%h | %an | %s" apache/release/1.0.x...apache/main | grep -v "Mend Renovate"

@github-project-automation github-project-automation bot moved this to PRs In Progress in Basic Kanban Board Aug 20, 2025
@pingtimeout pingtimeout changed the title Update changelog prior to 1.0.1 release Update changelog prior to 1.1.0 release Aug 20, 2025
Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a misunderstanding about what "breaking changes" are.

I don't mind to add another heading "Improvements" in addition to "Highlights", but most of the points in "breaking changes" are not breaking changes.

Copy link
Contributor Author

@pingtimeout pingtimeout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snazy thanks for the review, I am going to address some of them. But I want to give you a heads up about Github misleading UI. When people review the changelog, L45-L50 are collapsed, which makes it look like all the items added under ### New Feature were actually added to ### Breaking changes. But this is not the case. See attached screenshot.

Capture d’écran 2025-08-20 à 17 29 05

dimas-b
dimas-b previously approved these changes Aug 20, 2025
Copy link
Contributor

@dimas-b dimas-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for compiling this update @pingtimeout !

In the future let's try to proactively update CHANGELOG.md in PRs that are worth mentioning :)

@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Aug 20, 2025
@snazy
Copy link
Member

snazy commented Aug 20, 2025

@snazy thanks for the review, I am going to address some of them. But I want to give you a heads up about Github misleading UI. When people review the changelog, L45-L50 are collapsed, which makes it look like all the items added under ### New Feature were actually added to ### Breaking changes. But this is not the case.

Ah, yes, you're right. Ignore me.

@dimas-b
Copy link
Contributor

dimas-b commented Aug 20, 2025

@pingtimeout : heads up: merge conflict 😅

CHANGELOG.md Outdated

- Introduced S3 path-style access support for improved compatibility with S3-compatible storage systems.

- Added MinIO integration support with comprehensive getting started documentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put this in the highlight section? I think this is a big thing for people using s3-compatible storage.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok to move this to highlights, but s3-compatible support is not yet complete because of #2207... ATM, MinIO works, but systems without STS are not easy to use 🤷

flyrain
flyrain previously approved these changes Aug 20, 2025
Copy link
Contributor

@flyrain flyrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the update, @pingtimeout !

@pingtimeout pingtimeout dismissed stale reviews from flyrain and dimas-b via 6b518ae August 21, 2025 08:54
@pingtimeout
Copy link
Contributor Author

Thanks for the review. I just resolved the merge conflicts and moved the MinIO bullet point under highlights. Now waiting for CI...

@pingtimeout pingtimeout merged commit 2047dc2 into apache:main Aug 21, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Aug 21, 2025
@pingtimeout pingtimeout deleted the changelog-update-prior-to-1.0.1 branch August 21, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants