-
Notifications
You must be signed in to change notification settings - Fork 332
Update changelog prior to 1.1.0 release #2406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update changelog prior to 1.1.0 release #2406
Conversation
snazy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a misunderstanding about what "breaking changes" are.
I don't mind to add another heading "Improvements" in addition to "Highlights", but most of the points in "breaking changes" are not breaking changes.
pingtimeout
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snazy thanks for the review, I am going to address some of them. But I want to give you a heads up about Github misleading UI. When people review the changelog, L45-L50 are collapsed, which makes it look like all the items added under ### New Feature were actually added to ### Breaking changes. But this is not the case. See attached screenshot.
Co-authored-by: Robert Stupp <[email protected]>
dimas-b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks for compiling this update @pingtimeout !
In the future let's try to proactively update CHANGELOG.md in PRs that are worth mentioning :)
Ah, yes, you're right. Ignore me. |
|
@pingtimeout : heads up: merge conflict 😅 |
CHANGELOG.md
Outdated
|
|
||
| - Introduced S3 path-style access support for improved compatibility with S3-compatible storage systems. | ||
|
|
||
| - Added MinIO integration support with comprehensive getting started documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we put this in the highlight section? I think this is a big thing for people using s3-compatible storage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok to move this to highlights, but s3-compatible support is not yet complete because of #2207... ATM, MinIO works, but systems without STS are not easy to use 🤷
flyrain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the update, @pingtimeout !
|
Thanks for the review. I just resolved the merge conflicts and moved the MinIO bullet point under highlights. Now waiting for CI... |
Command to list all commits that were added to
mainand that are not already included in 1.1.0: