Skip to content

Quickstart documentation contained an error around starting Polaris using docker compose #1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Quickstart documentation contained an error around starting Polaris using docker compose #1660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af5978e
Update path to docker compose file for postgres
May 22, 2025
d47bc68
Updates to allow postgres to start and accept local connections
May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion getting-started/assets/postgres/docker-compose-postgres.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,11 @@ services:
volumes:
# Bind local conf file to a convenient location in the container
- type: bind
source: ../assets/postgres/postgresql.conf
source: postgresql.conf
target: /etc/postgresql/postgresql.conf
- type: bind
source: pg_hba.conf
target: /etc/postgresql/pg_hba.conf
command:
- "postgres"
- "-c"
Expand Down
2 changes: 2 additions & 0 deletions getting-started/assets/postgres/pg_hba.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
host all all all md5
Copy link
Contributor

@adnanhemani adnanhemani May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find the need for this personally when running against the provided Postgres Docker image or against cloud providers. Are you using one of these deployment options?

Copy link
Author

@hildo hildo May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using what is defined.. I did not think I was using different containers... if I did not do this, the bootstrap failed because connections to the Postgres database were rejected (it was complaining about a missing pg_hba.conf, so I gave it one). Should the expected container have this?

Copy link
Author

@hildo hildo May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this is what's being used

edward.hillmann@U-RK427UANA9TF:~/sandbox/polaris-src/polaris$ docker container ls
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
6da1eaec6c26 postgres:17.5 "docker-entrypoint.s…" 49 minutes ago Up 7 minutes (healthy) 0.0.0.0:5432->5432/tcp, [::]:5432->5432/tcp postgres-postgres-1

hostnossl all all all md5
2 changes: 1 addition & 1 deletion getting-started/eclipselink/docker-compose-bootstrap-db.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ services:
polaris.persistence.type: eclipse-link
polaris.persistence.eclipselink.configuration-file: /deployments/config/eclipselink/persistence.xml
volumes:
- ../assets/eclipselink/:/deployments/config/eclipselink
Copy link
Contributor

@adnanhemani adnanhemani May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert the changes related to the assets folder. There's a better solution than playing with the relative paths in #1610 that I think would be best to use instead - but we're slight a slight bit off from merging that PR through just yet.

Copy link
Author

@hildo hildo May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I'm happy if we abandon this and work with what's started in #1610 ... do you think we should update the doco changes in that PR as well?

Copy link
Author

@hildo hildo May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IT does look like the doco change I applied are also in 1610.. so this can be abandoned... thanks!

- ../eclipselink/:/deployments/config/eclipselink
command:
- "bootstrap"
- "--realm=POLARIS"
Expand Down
2 changes: 1 addition & 1 deletion site/content/in-dev/unreleased/getting-started/quickstart.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ cd ~/polaris
:polaris-quarkus-admin:assemble --rerun \
-Dquarkus.container-image.tag=postgres-latest \
-Dquarkus.container-image.build=true
docker compose -f getting-started/eclipselink/docker-compose-postgres.yml -f getting-started/eclipselink/docker-compose-bootstrap-db.yml -f getting-started/eclipselink/docker-compose.yml up
docker compose -f getting-started/assets/postgres/docker-compose-postgres.yml -f getting-started/eclipselink/docker-compose-bootstrap-db.yml -f getting-started/eclipselink/docker-compose.yml up
```

You should see output for some time as Polaris, Spark, and Trino build and start up. Eventually, you won’t see any more logs and see some logs relating to Spark, resembling the following:
Expand Down