Quickstart documentation contained an error around starting Polaris using docker compose #1660
Conversation
adnanhemani
left a comment
adnanhemani
left a comment
There was a problem hiding this comment.
LGTM - thanks for catching this!
|
Please do hit "Publish" on this PR :) |
hildo
requested review from
HonahX,
MonkeyCanCode,
RussellSpitzer,
adutra,
ajantha-bhat,
ashvina,
collado-mike,
dennishuo,
dimas-b,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
pingtimeout,
singhpk234,
snazy,
takidau and
vvcephei
as code owners
|
@adnanhemani happy to help! I did find that I needed to tweak the Postgres settings to allow connections to be accepted.. So I have pushed more changes. Please let me know if this is still suitable or not. |
| @@ -0,0 +1,2 @@ | |||
| host all all all md5 | |||
There was a problem hiding this comment.
I didn't find the need for this personally when running against the provided Postgres Docker image or against cloud providers. Are you using one of these deployment options?
There was a problem hiding this comment.
I am using what is defined.. I did not think I was using different containers... if I did not do this, the bootstrap failed because connections to the Postgres database were rejected (it was complaining about a missing pg_hba.conf, so I gave it one). Should the expected container have this?
There was a problem hiding this comment.
FYI, this is what's being used
edward.hillmann@U-RK427UANA9TF:~/sandbox/polaris-src/polaris$ docker container ls
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
6da1eaec6c26 postgres:17.5 "docker-entrypoint.s…" 49 minutes ago Up 7 minutes (healthy) 0.0.0.0:5432->5432/tcp, [::]:5432->5432/tcp postgres-postgres-1
| polaris.persistence.type: eclipse-link | ||
| polaris.persistence.eclipselink.configuration-file: /deployments/config/eclipselink/persistence.xml | ||
| volumes: | ||
| - ../assets/eclipselink/:/deployments/config/eclipselink |
There was a problem hiding this comment.
Let's revert the changes related to the assets folder. There's a better solution than playing with the relative paths in #1610 that I think would be best to use instead - but we're slight a slight bit off from merging that PR through just yet.
There was a problem hiding this comment.
yes, I'm happy if we abandon this and work with what's started in #1610 ... do you think we should update the doco changes in that PR as well?
There was a problem hiding this comment.
IT does look like the doco change I applied are also in 1610.. so this can be abandoned... thanks!
github-project-automation
bot
moved this from PRs In Progress
to Done
in Basic Kanban Board
|
Closing, as this has been addressed in another PR |
2 participants
Hello. I was interested in learning more about Polaris, and when to run an instance up using the instructions in the documentation. I reached the docker-compose example for starting polaris and the command failed.
Specifically, the docker compose command was attempting to use the file "getting-started/eclipselink/docker-compose-postgres.yml" to start postgres and that file did not exist.
I noticed there was a file at "getting-started/assets/postgres/docker-compose-postgres.yaml", and when I updated the command it was able to progress.
This PR has an update to the documentation to reflect the new location.