fix(build): Pin home version after merging #1764 #1783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liurenjie1024
approved these changes
Oct 24, 2025
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @mbutrovich for this fix!
mbutrovich
added a commit
to mbutrovich/iceberg-rust
that referenced
this pull request
Oct 25, 2025
(cherry picked from commit ddbcae4)
liurenjie1024
pushed a commit
that referenced
this pull request
Oct 27, 2025
## Which issue does this PR close? - A minor followup of #1783 ## What changes are included in this PR? - Update Cargo.lock to add home ## Are these changes tested? No
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The MSRV check was failing because the
homecrate version 0.5.12 bumped its minimum supported Rust version to 1.88, while iceberg-rust maintains an MSRV of 1.87. Thehomecrate is a transitive dependency brought in throughdatafusion-cli->rustylineandreqsign.What changes are included in this PR?
homecrate to version0.5.11Are these changes tested?
Yes, verified with
make check-msrv. CI will also check it.