-
Notifications
You must be signed in to change notification settings - Fork 343
feat(sqllogictest): Add support for iceberg datafusion sqllogictest integration #1764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Getting |
liurenjie1024
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lliangyu-lin for this pr!
| - macos-latest | ||
| - windows-latest | ||
| steps: | ||
| - name: Maximize build space (Ubuntu) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is same used in unit test workflow: https://github.com/apache/iceberg-rust/blob/main/.github/workflows/ci.yml#L128-L131
liurenjie1024
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lliangyu-lin for this pr, generally LGTM! Just one minor nit.
| [engines] | ||
| df = { type = "datafusion" } | ||
|
|
||
| [catalog] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this any more? If so, it would be confusing to put it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[catalog] is not needed for now. Removed in the new commit.
liurenjie1024
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lliangyu-lin for this pr!
(cherry picked from commit ddbcae4)
Which issue does this PR close?
What changes are included in this PR?
sqllogictests.rsScheduleto trackEngineRunnerinstead ofEngineAre these changes tested?
cargo test --test sqllogictests