Add cli for iceberg #1194
Merged
Add cli for iceberg #1194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Blocked by #1196 |
Member
|
Hi, MSRV failed means that |
Xuanwo
reviewed
Apr 11, 2025
Signed-off-by: Ray Liu <[email protected]>
liurenjie1024
force-pushed
the
ray/1142-2
branch
from
af296fc to
ad3a730
Compare
xxchan
reviewed
Apr 12, 2025
Xuanwo
approved these changes
Apr 13, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you @liurenjie1024 for starting this experiment!
liurenjie1024
pushed a commit
that referenced
this pull request
Apr 14, 2025
## Which issue does this PR close? - remove tap, it's not needed any more after #1203. Added by mistake in #1194 - remove cargo update in minimal versions gen, since we put them in Cargo.toml now. (#1203 (comment)) - bump reqwest, bytes to newer version to resolve some minimal version build issue (not latest) - Closes #. --------- Signed-off-by: xxchan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Initial support for iceberg cli.
Are these changes tested?
Tested in local env, this is early version, will add more tests later.