feat: Support PartitionStats
#1111
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…athanc-n/iceberg-rust into partition-statistics-handler
Contributor
Author
|
@Xuanwo @Fokko @sdd @liurenjie1024 This should be ready for review |
Xuanwo
reviewed
May 10, 2025
| Ok(()) | ||
| } | ||
|
|
||
| fn update_snapshot_info(&mut self, snapshot_id: i64, updated_at: i64) { |
Member
There was a problem hiding this comment.
If we only use update_snapshot_info internally, is it better to have seperate APIs like update_with_data_file and refresh_with_snapshot?
Contributor
Author
There was a problem hiding this comment.
I believe its safer to just have update_snapshot_info kept like this because if users are going to update the statistics for the latest snapshot this should always be called alongside it. I think it is quite dangerous to not update to latest snapshot when updating because it is incorrect if the user forgets to call the API to refresh. It will also be used for other partition stat updates as seen in the java implementation here.
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #1102
What changes are included in this PR?
Added partition stats outline
Are these changes tested?