Added support for lowercase FileFormat for Issue #1340 #1362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the FileFormat class so that it utilizes EnumMeta value aliases. This allows both "AVRO" and "avro" to map to AVRO.
Contributor
|
thanks for the contribution! do you mind adding a few test cases to validate the new behavior? in the original issue, the Datafile has to set |
Contributor
|
@hgollakota It looks like there is a formatting issue, could you run |
Fokko
reviewed
Jan 15, 2025
Fokko
approved these changes
Jan 15, 2025
Contributor
|
@Fokko this PR is failing CI https://github.com/apache/iceberg-python/actions/runs/12792587045/job/35663397601 |
Fokko
added a commit
to Fokko/iceberg-python
that referenced
this pull request
Jan 15, 2025
This reverts commit 4e75599.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the FileFormat class so that it utilizes EnumMeta value aliases.
This allows specifying both "AVRO" and "avro" to map to AVRO, for example.
This addresses Issue #1340
Closes #1340