Add _missing_ to make FileFormat case insensitive
#1411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hey @kevinjqliu @Fokko, this PR is ready for review. Rather than modifying the |
Fokko
approved these changes
Dec 9, 2024
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Looks good, thanks @jiakai-li for fixing this 🙌
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 24, 2024
* Add _missing_ to FileFormat Enum to make it case insensitive * Combine the manifest test to existing test_manifest.py file * Fix linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes:
file_formatto be lower-case #1340 *The change is to make
FileFormatcase insensitve. The idea is to add_missing_funtion to handle lower case in a pythonic way.Also included corresponding test at
tests/test_manifest.py.