Skip to content

HBASE-29038 Fix NPE in processRS.jsp due to missing MBean value #6556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025
Merged

HBASE-29038 Fix NPE in processRS.jsp due to missing MBean value #6556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions hbase-server/src/main/resources/hbase-webapps/regionserver/processRS.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@
RuntimeMXBean runtimeBean = ManagementFactory.getRuntimeMXBean();
ObjectName jvmMetrics = new ObjectName("Hadoop:service=HBase,name=JvmMetrics");
ObjectName rsMetrics = new ObjectName("Hadoop:service=HBase,name=RegionServer,sub=Server");
Object pauseWarnThresholdExceeded = JSONMetricUtil.getValueFromMBean(rsMetrics, "pauseWarnThresholdExceeded");
Object pauseInfoThresholdExceeded = JSONMetricUtil.getValueFromMBean(rsMetrics, "pauseInfoThresholdExceeded");

// There is always two of GC collectors
List<GarbageCollectorMXBean> gcBeans = JSONMetricUtil.getGcCollectorBeans();
Expand Down Expand Up @@ -60,16 +62,16 @@ pageContext.setAttribute("pageTitle", "Process info for PID: " + JSONMetricUtil.
<th>Started</th>
<th>Uptime</th>
<th>PID</th>
<th>JvmPauseMonitor Count </th>
<th>JvmPauseMonitor Count</th>
<th>Owner</th>
</tr>
<tr>
<tr>
<td><%= new Date(runtimeBean.getStartTime()) %></td>
<td><%= StringUtils.humanTimeDiff(runtimeBean.getUptime()) %></td>
<td><%= JSONMetricUtil.getProcessPID() %></td>
<td><%= (long)JSONMetricUtil.getValueFromMBean(rsMetrics, "pauseWarnThresholdExceeded")
+ (long)JSONMetricUtil.getValueFromMBean(rsMetrics, "pauseInfoThresholdExceeded") %></td>
<td><%= pauseWarnThresholdExceeded != null && pauseInfoThresholdExceeded != null ?
(long)pauseWarnThresholdExceeded + (long)pauseInfoThresholdExceeded : 0 %></td>
<td><%= runtimeBean.getSystemProperties().get("user.name") %></td>
</tr>
</table>
Expand Down