Skip to content

HBASE-29038 Fix NPE in processRS.jsp due to missing MBean value #6556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2025
Merged

HBASE-29038 Fix NPE in processRS.jsp due to missing MBean value #6556

merged 1 commit into from
Feb 14, 2025

Conversation

@aaronbee
Copy link
Contributor

No description provided.

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
guluo2016
guluo2016 reviewed Dec 23, 2024
View reviewed changes
hbase-server/src/main/resources/hbase-webapps/regionserver/processRS.jsp Outdated
<td><%= (long)JSONMetricUtil.getValueFromMBean(rsMetrics, "pauseWarnThresholdExceeded")
+ (long)JSONMetricUtil.getValueFromMBean(rsMetrics, "pauseInfoThresholdExceeded") %></td>
<td><%= pauseWarnThresholdExceeded != null && pauseInfoThresholdExceeded != null ?
(long)pauseWarnThresholdExceeded + (long)pauseInfoThresholdExceeded : -1 %></td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to display 0 if it's null? I'm not sure, maybe we can hear other people's opinions?

<th>JvmPauseMonitor Count </th> , Can you also remove this space in line65?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to replace with whatever is preferred. How about the string "unknown"?

Copy link
Contributor Author

@aaronbee aaronbee Dec 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the value to 0 when the metrics are null. And fixed the spacing on line 65.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no more questions. let's wait for others to review.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 35s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 3m 49s master passed
+1 💚 spotless 0m 43s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 6s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 spotless 1m 3s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 15s The patch does not generate ASF License warnings.
11m 5s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6556/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6556
Optional Tests dupname asflicense javac codespell detsecrets spotless
uname Linux 9cc67021bfce 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 7cabaf1
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6556/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 29s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 18s master passed
+1 💚 javadoc 0m 28s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 1s the patch passed
+1 💚 javadoc 0m 26s the patch passed
_ Other Tests _
+1 💚 unit 183m 13s hbase-server in the patch passed.
195m 19s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6556/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6556
Optional Tests javac javadoc unit
uname Linux 4d6bd5276e33 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 7cabaf1
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6556/2/testReport/
Max. process+thread count 5031 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6556/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 merged commit c9f7dad into apache:master Feb 14, 2025
1 check passed
Apache9 pushed a commit that referenced this pull request Feb 14, 2025
@aaronbee @Apache9
HBASE-29038 Fix NPE in processRS.jsp due to missing MBean value (#6556)
6aa9adc 
Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit c9f7dad)
Apache9 pushed a commit that referenced this pull request Feb 14, 2025
@aaronbee @Apache9
HBASE-29038 Fix NPE in processRS.jsp due to missing MBean value (#6556)
195998a 
Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit c9f7dad)
Apache9 pushed a commit that referenced this pull request Feb 14, 2025
@aaronbee @Apache9
HBASE-29038 Fix NPE in processRS.jsp due to missing MBean value (#6556)
7b892a2 
Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit c9f7dad)
Apache9 pushed a commit that referenced this pull request Feb 14, 2025
@aaronbee @Apache9
HBASE-29038 Fix NPE in processRS.jsp due to missing MBean value (#6556)
cceaaf3 
Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit c9f7dad)
@aaronbee aaronbee deleted the processRS_fix branch February 18, 2025 17:34
mokai87 pushed a commit to mokai87/hbase that referenced this pull request Aug 7, 2025
@aaronbee @mokai87
HBASE-29038 Fix NPE in processRS.jsp due to missing MBean value (apac…
5eeaebc 
…he#6556)

Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit c9f7dad)
sanjeet006py pushed a commit to sanjeet006py/hbase that referenced this pull request Sep 26, 2025
@aaronbee
HBASE-29038 Fix NPE in processRS.jsp due to missing MBean value (apac…
a17801c 
…he#6556)

Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit c9f7dad)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guluo2016 guluo2016 guluo2016 left review comments

@Apache9 Apache9 Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aaronbee @Apache-HBase @Apache9 @guluo2016