HBASE-26337 Optimization for weighted random generators #3732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
changed the title
Apache9
reviewed
Nov 6, 2021
There was a problem hiding this comment.
Mind explaining more about the logic here?
Looking at the comment on jira, the candidate generator could perform better for specific cost functions. For example, if the cost function is load based, then LoadCandidateGenerator will be better.
Looking at the code, I guess the algorithm here, is to use the cost of different cost functions as the weight for different generators, for example, if load based cost functions have donated most of the final cost, then we'd better choose LoadCandidateGenerator. Is this what you plan to do? If so, please add more javadoc or comments to explain this.
|
|
||
| protected abstract double cost(); | ||
|
|
||
| protected void updateWeight(double[] weights) { |
There was a problem hiding this comment.
Where do we call this method?
There was a problem hiding this comment.
added the missing commits lost in rebase.
| .generate(cluster); | ||
| } | ||
|
|
||
| private CandidateGenerator getRandomGenerate() { |
There was a problem hiding this comment.
We do not call this private method?
...e-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
Show resolved
Hide resolved
|
@Apache9 thank you for review. Sorry for missing a commit during rebase. added it back and updated for review feedback. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
The checks passed but the results are not rolled up. Is there anything we can do? @Apache9 |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
The only failure TEST-org.apache.hadoop.hbase.replication.TestReplicationEmptyWALRecovery.xml.[failed-to-read] is known unrelated issue. The javac complaint is about out a commit already reverted. "[WARNING] /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3732/yetus-general-check/src/hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredNodeLoadPicker.java:[35,30] [UnusedVariable] The field 'LOG' is never read." Push with squash to trigger a rerun. |
…ation" This reverts commit 8d2be34.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Rerun still had the wrong complaint for Javac and unrelated test failures. Made a new branch from master with all commits squashed for a clean PR to rerun. #3827 |
Apache9
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #3710
rebased to get the dependency.