Skip to content

Conversation

@busbey
Copy link
Contributor

@busbey busbey commented Mar 9, 2018

…fer to the wrong workspace

'''
dir ("${env.TOOLS}") {
// Set up the file we need at PERSONALITY_FILE location
dir ("tools") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will always be relative to root? To $BASEDIR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's relative to the workspace root.

Copy link
Contributor Author

@busbey busbey Mar 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at the end of this stage we stash the tools directory and in future stages we unstash it relative to those stages' workspace root.

jdk "JDK 1.8 (latest)"
}
environment {
BASEDIR = "${env.WORKSPACE}/component"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between ${BASEDIR} and ${env.BASEDIR} below

Do they both read this value, or does only env.BASEDIR read this and the other one comes from ~magic

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

env.BASEDIR gets replaced with the literal value by jenkins. BASEDIR is a bash variable that will be set to a value of the same thing that Jenkins would rewrite.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one doesn't have a node? so where does it exec?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stages that don't have their own node label exec on the same node as the task that launches the entire pipeline (so the one that runs the "install yetus" and "init health results" steps)

}
}
environment {
BASEDIR = "${env.WORKSPACE}/component"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I... don't understand how these are different from what we had previously?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the captured context is different. jenkins captures things like WORKSPACE per executor. how it turns the given stages and initial environment into executors is magic AFAICT.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so down here, because we had a node on the stage we get a new executor and a new WORKSPACE gets made.

@busbey
Copy link
Contributor Author

busbey commented Mar 9, 2018

ugh, lack of jira integration / notifications.

@busbey busbey closed this Apr 11, 2018
udaynpusa pushed a commit to mapr/hbase that referenced this pull request Jan 30, 2024
HBASE-201 CVE-2016-6796: Tomcat / Jasper library vulnerability
ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants