-
Couldn't load subscription status.
- Fork 3.4k
HBASE-26087 JVM crash when displaying RPC params by MonitoredRPCHandler #3489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandlerImpl.java
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandlerImpl.java
Outdated
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Rerunning tests but the failed test seems unrelated.... a flakey. Safe to merge IMO. |
|
💔 -1 overall
This message was automatically generated. |
…er (#3489) Signed-off-by: stack <[email protected]>
…er (#3489) Signed-off-by: stack <[email protected]>
…er (#3489) Signed-off-by: stack <[email protected]>
…er (#3489) Signed-off-by: stack <[email protected]>
|
Sorry for finding the spotbugs after merged to master. I have added an addendum to master, and branch2.3+ are with the fixed patch. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Where is the spotbugs fix @sunhelly ? Do it in a new PR? ^^ NVM, I see it now. Thanks. |
Please see more details at https://issues.apache.org/jira/browse/HBASE-26087
The added UT TestTaskMonitor#testClone will fail without this patch. It simulates the referred offheap ByteBuffer of the param change in the clone MonitoredRPCHandler.