HBASE-25522 Remove deprecated methods in ReplicationPeerConfig #2898

ZhaoBQ · 2021-01-21T06:40:00Z

No description provided.

Apache-HBase · 2021-01-21T07:35:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 1s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 25s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 46s	master passed
+1 💚	compile	4m 5s	master passed
+1 💚	checkstyle	1m 31s	master passed
+1 💚	spotbugs	2m 57s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 25s	the patch passed
+1 💚	compile	4m 6s	the patch passed
+1 💚	javac	4m 6s	the patch passed
-0 ⚠️	checkstyle	0m 27s	hbase-client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️	checkstyle	1m 4s	hbase-server: The patch generated 4 new + 26 unchanged - 0 fixed = 30 total (was 26)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	17m 19s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	3m 16s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 26s	The patch does not generate ASF License warnings.
		54m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2898
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux e3508c2c8530 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5c13c68`
Default Java	AdoptOpenJDK-1.8.0_232-b09
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-21T08:00:22Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	19m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 36s	Maven dependency ordering for branch
+1 💚	mvninstall	7m 20s	master passed
+1 💚	compile	2m 28s	master passed
+1 💚	shadedjars	9m 26s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 43s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	6m 23s	the patch passed
+1 💚	compile	2m 26s	the patch passed
+1 💚	javac	2m 26s	the patch passed
+1 💚	shadedjars	9m 14s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 31s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 47s	hbase-client in the patch passed.
-1 ❌	unit	13m 54s	hbase-server in the patch failed.
		78m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2898
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ced9abc80375 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5c13c68`
Default Java	AdoptOpenJDK-11.0.6+10
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/1/testReport/
Max. process+thread count	619 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-21T10:57:31Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	10m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 25s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 27s	master passed
+1 💚	compile	1m 22s	master passed
+1 💚	shadedjars	7m 10s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 59s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 58s	the patch passed
+1 💚	compile	1m 25s	the patch passed
+1 💚	javac	1m 25s	the patch passed
+1 💚	shadedjars	7m 8s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 57s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 7s	hbase-client in the patch passed.
-1 ❌	unit	214m 7s	hbase-server in the patch failed.
		256m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2898
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux eac9b4387ca6 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5c13c68`
Default Java	AdoptOpenJDK-1.8.0_232-b09
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/1/testReport/
Max. process+thread count	3553 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-21T16:03:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	9m 12s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 10s	master passed
+1 💚	compile	4m 33s	master passed
+1 💚	checkstyle	1m 40s	master passed
+1 💚	spotbugs	3m 22s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 2s	the patch passed
+1 💚	compile	4m 28s	the patch passed
+1 💚	javac	4m 28s	the patch passed
-0 ⚠️	checkstyle	0m 28s	hbase-client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️	checkstyle	1m 10s	hbase-server: The patch generated 4 new + 26 unchanged - 0 fixed = 30 total (was 26)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	21m 49s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	4m 17s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 26s	The patch does not generate ASF License warnings.
		69m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2898
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 975dcadd1c1c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5c13c68`
Default Java	AdoptOpenJDK-1.8.0_232-b09
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-21T17:49:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 24s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 45s	master passed
+1 💚	compile	1m 46s	master passed
+1 💚	shadedjars	7m 4s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 11s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 12s	the patch passed
+1 💚	compile	1m 49s	the patch passed
+1 💚	javac	1m 49s	the patch passed
+1 💚	shadedjars	8m 42s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 14s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 12s	hbase-client in the patch passed.
+1 💚	unit	135m 39s	hbase-server in the patch passed.
		174m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2898
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 411944bac078 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5c13c68`
Default Java	AdoptOpenJDK-11.0.6+10
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/2/testReport/
Max. process+thread count	4749 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-21T19:13:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	9m 7s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 13s	master passed
+1 💚	compile	1m 33s	master passed
+1 💚	shadedjars	7m 29s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 3s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 3s	the patch passed
+1 💚	compile	1m 35s	the patch passed
+1 💚	javac	1m 35s	the patch passed
+1 💚	shadedjars	7m 22s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 0s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 15s	hbase-client in the patch passed.
+1 💚	unit	217m 49s	hbase-server in the patch passed.
		259m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2898
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 094e6711fdeb 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5c13c68`
Default Java	AdoptOpenJDK-1.8.0_232-b09
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/2/testReport/
Max. process+thread count	3255 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2021-01-22T02:06:31Z

Please fix the checkstyle issues?

Apache-HBase · 2021-01-22T03:23:13Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 35s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 33s	master passed
+1 💚	compile	4m 8s	master passed
+1 💚	checkstyle	1m 31s	master passed
+1 💚	spotbugs	3m 4s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 30s	the patch passed
+1 💚	compile	4m 5s	the patch passed
+1 💚	javac	4m 5s	the patch passed
+1 💚	checkstyle	1m 31s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	17m 11s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	3m 17s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 25s	The patch does not generate ASF License warnings.
		51m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2898
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 34c2e93dad6a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5c13c68`
Default Java	AdoptOpenJDK-1.8.0_232-b09
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-22T06:37:04Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 20s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 29s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 58s	master passed
+1 💚	compile	1m 24s	master passed
+1 💚	shadedjars	7m 11s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 57s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 50s	the patch passed
+1 💚	compile	1m 23s	the patch passed
+1 💚	javac	1m 23s	the patch passed
+1 💚	shadedjars	7m 5s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 58s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 8s	hbase-client in the patch passed.
-1 ❌	unit	211m 29s	hbase-server in the patch failed.
		245m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2898
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7dbda21e57ae 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5c13c68`
Default Java	AdoptOpenJDK-1.8.0_232-b09
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/3/testReport/
Max. process+thread count	3541 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-22T06:41:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 15s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 30s	Maven dependency ordering for branch
+1 💚	mvninstall	6m 2s	master passed
+1 💚	compile	2m 9s	master passed
+1 💚	shadedjars	8m 48s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 33s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	6m 6s	the patch passed
+1 💚	compile	2m 15s	the patch passed
+1 💚	javac	2m 15s	the patch passed
+1 💚	shadedjars	9m 21s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 28s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 34s	hbase-client in the patch passed.
-1 ❌	unit	204m 30s	hbase-server in the patch failed.
		248m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2898
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0044e913dc76 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5c13c68`
Default Java	AdoptOpenJDK-11.0.6+10
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/3/testReport/
Max. process+thread count	3040 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ZhaoBQ · 2021-01-22T07:06:40Z

Mockito cannot mock/spy because ReplicationPeerConfig is final class. Modify it back and ignore the checkstyle.

Apache-HBase · 2021-01-22T08:02:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 37s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 36s	master passed
+1 💚	compile	4m 2s	master passed
+1 💚	checkstyle	1m 31s	master passed
+1 💚	spotbugs	2m 55s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 26s	the patch passed
+1 💚	compile	4m 4s	the patch passed
+1 💚	javac	4m 4s	the patch passed
-0 ⚠️	checkstyle	0m 27s	hbase-client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	17m 12s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	3m 19s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 25s	The patch does not generate ASF License warnings.
		51m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2898
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 283a541ad060 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5c13c68`
Default Java	AdoptOpenJDK-1.8.0_232-b09
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/4/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-22T11:06:56Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 16s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 43s	master passed
+1 💚	compile	1m 47s	master passed
+1 💚	shadedjars	7m 27s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 11s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 53s	the patch passed
+1 💚	compile	1m 45s	the patch passed
+1 💚	javac	1m 45s	the patch passed
+1 💚	shadedjars	7m 36s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 22s	hbase-client in the patch passed.
+1 💚	unit	200m 1s	hbase-server in the patch passed.
		235m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2898
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7f6ac386c23d 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5c13c68`
Default Java	AdoptOpenJDK-11.0.6+10
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/4/testReport/
Max. process+thread count	2683 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-22T12:07:49Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 19s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 52s	master passed
+1 💚	compile	1m 26s	master passed
+1 💚	shadedjars	7m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 57s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 51s	the patch passed
+1 💚	compile	1m 25s	the patch passed
+1 💚	javac	1m 25s	the patch passed
+1 💚	shadedjars	7m 9s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 0s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 8s	hbase-client in the patch passed.
-1 ❌	unit	260m 51s	hbase-server in the patch failed.
		296m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2898
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 5c1fd63d2dd9 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5c13c68`
Default Java	AdoptOpenJDK-1.8.0_232-b09
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/4/testReport/
Max. process+thread count	2587 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani

Left one comment to reuse same builder object, rest looks good.
Nice cleanup @ZhaoBQ

virajjasani · 2021-01-22T15:00:18Z

hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncReplicationAdminApi.java

+    ReplicationPeerConfig rpc = ReplicationPeerConfig.newBuilder().setClusterKey(KEY_ONE).build();
    admin.addReplicationPeer(ID_ONE, rpc).join();
-    rpc.setReplicateAllUserTables(false);
+    rpc = ReplicationPeerConfig.newBuilder(rpc).setReplicateAllUserTables(false).build();


Rather than creating a new builder from rpc, we can reuse old one.
e.g

ReplicationPeerConfigBuilder rpcBuilder = ReplicationPeerConfig.newBuilder().setClusterKey(KEY_ONE); admin.addReplicationPeer(ID_ONE, rpcBuilder.build()).join(); rpcBuilder.setReplicateAllUserTables(false); admin.updateReplicationPeerConfig(ID_ONE, rpcBuilder.build()).join();

Applicable to other similar places.

Thanks for the nice suggestion, fix it immediately.

Apache-HBase · 2021-01-23T04:39:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 20s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 6s	master passed
+1 💚	compile	4m 17s	master passed
+1 💚	checkstyle	1m 42s	master passed
+1 💚	spotbugs	3m 11s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 52s	the patch passed
+1 💚	compile	4m 11s	the patch passed
+1 💚	javac	4m 11s	the patch passed
-0 ⚠️	checkstyle	0m 27s	hbase-client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️	checkstyle	1m 14s	hbase-server: The patch generated 1 new + 26 unchanged - 0 fixed = 27 total (was 26)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 15s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	3m 28s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 23s	The patch does not generate ASF License warnings.
		56m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2898
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 88444ad9ed67 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f39636c`
Default Java	AdoptOpenJDK-1.8.0_232-b09
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/5/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-23T06:54:32Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 25s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 48s	master passed
+1 💚	compile	1m 36s	master passed
+1 💚	shadedjars	8m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 15s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 28s	the patch passed
+1 💚	compile	1m 43s	the patch passed
+1 💚	javac	1m 43s	the patch passed
+1 💚	shadedjars	8m 26s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 12s	hbase-client in the patch passed.
-1 ❌	unit	151m 42s	hbase-server in the patch failed.
		190m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2898
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 5bf0d76b9955 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f39636c`
Default Java	AdoptOpenJDK-1.8.0_232-b09
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/5/testReport/
Max. process+thread count	3787 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-23T07:59:35Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 54s	Maven dependency ordering for branch
+1 💚	mvninstall	7m 5s	master passed
+1 💚	compile	2m 19s	master passed
+1 💚	shadedjars	9m 35s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 32s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	6m 4s	the patch passed
+1 💚	compile	2m 11s	the patch passed
+1 💚	javac	2m 11s	the patch passed
+1 💚	shadedjars	9m 3s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 29s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 54s	hbase-client in the patch passed.
-1 ❌	unit	208m 30s	hbase-server in the patch failed.
		255m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2898
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 891c60b882de 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f39636c`
Default Java	AdoptOpenJDK-11.0.6+10
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/5/testReport/
Max. process+thread count	2818 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-23T08:53:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 43s	master passed
+1 💚	compile	4m 10s	master passed
+1 💚	checkstyle	1m 32s	master passed
+1 💚	spotbugs	3m 0s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 32s	the patch passed
+1 💚	compile	4m 22s	the patch passed
+1 💚	javac	4m 22s	the patch passed
-0 ⚠️	checkstyle	0m 27s	hbase-client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️	checkstyle	1m 5s	hbase-server: The patch generated 1 new + 26 unchanged - 0 fixed = 27 total (was 26)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	17m 30s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	3m 13s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 26s	The patch does not generate ASF License warnings.
		51m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2898
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 4e715e274344 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f39636c`
Default Java	AdoptOpenJDK-1.8.0_232-b09
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/6/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-23T11:56:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 13s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 5s	master passed
+1 💚	compile	2m 11s	master passed
+1 💚	shadedjars	8m 21s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 14s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 40s	the patch passed
+1 💚	compile	1m 45s	the patch passed
+1 💚	javac	1m 45s	the patch passed
+1 💚	shadedjars	7m 31s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 28s	hbase-client in the patch passed.
+1 💚	unit	195m 17s	hbase-server in the patch passed.
		234m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2898
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 729aeea157f8 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f39636c`
Default Java	AdoptOpenJDK-11.0.6+10
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/6/testReport/
Max. process+thread count	2802 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/6/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-23T12:04:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 37s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 8s	master passed
+1 💚	compile	1m 27s	master passed
+1 💚	shadedjars	7m 15s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 59s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 28s	the patch passed
+1 💚	compile	1m 28s	the patch passed
+1 💚	javac	1m 28s	the patch passed
+1 💚	shadedjars	7m 50s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 59s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 9s	hbase-client in the patch passed.
+1 💚	unit	208m 25s	hbase-server in the patch passed.
		242m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2898
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e263f9e24291 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f39636c`
Default Java	AdoptOpenJDK-1.8.0_232-b09
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/6/testReport/
Max. process+thread count	2699 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2898/6/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ZhaoBQ force-pushed the HBASE-25522 branch from 7d448a3 to efe5583 Compare January 21, 2021 14:53

HBASE-25522 Remove deprecated methods in ReplicationPeerConfig

1fddc19

ZhaoBQ force-pushed the HBASE-25522 branch from 64517e4 to 1fddc19 Compare January 22, 2021 07:10

virajjasani reviewed Jan 22, 2021

View reviewed changes

ZhaoBQ added 2 commits January 23, 2021 11:42

reuse ReplicationPeerConfigBuilder

15c6111

reuse ReplicationPeerConfigBuilder

f9ed9cf

virajjasani approved these changes Jan 24, 2021

View reviewed changes

virajjasani merged commit 0b0cdca into apache:master Jan 24, 2021

Uh oh!

HBASE-25522 Remove deprecated methods in ReplicationPeerConfig #2898

HBASE-25522 Remove deprecated methods in ReplicationPeerConfig #2898

Uh oh!

Conversation

ZhaoBQ commented Jan 21, 2021

Uh oh!

Apache-HBase commented Jan 21, 2021

Uh oh!

Apache-HBase commented Jan 21, 2021

Uh oh!

Apache-HBase commented Jan 21, 2021

Uh oh!

Apache-HBase commented Jan 21, 2021

Uh oh!

Apache-HBase commented Jan 21, 2021

Uh oh!

Apache-HBase commented Jan 21, 2021

Uh oh!

Apache9 commented Jan 22, 2021

Uh oh!

Apache-HBase commented Jan 22, 2021

Uh oh!

Apache-HBase commented Jan 22, 2021

Uh oh!

Apache-HBase commented Jan 22, 2021

Uh oh!

ZhaoBQ commented Jan 22, 2021

Uh oh!

Apache-HBase commented Jan 22, 2021

Uh oh!

Apache-HBase commented Jan 22, 2021

Uh oh!

Apache-HBase commented Jan 22, 2021

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

virajjasani Jan 22, 2021

Choose a reason for hiding this comment

Uh oh!

ZhaoBQ Jan 23, 2021

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Jan 23, 2021

Uh oh!

Apache-HBase commented Jan 23, 2021

Uh oh!

Apache-HBase commented Jan 23, 2021

Uh oh!

Apache-HBase commented Jan 23, 2021

Uh oh!

Apache-HBase commented Jan 23, 2021

Uh oh!

Apache-HBase commented Jan 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants