HBASE-25329 Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time #2761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
2 similar comments
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
caroliney14
force-pushed
the
HBASE-25329
branch
from
9978a2f to
59962a4
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
reviewed
Jan 5, 2021
| if (oldestRITTime < ritTime) { | ||
| oldestRITTime = ritTime; | ||
| } | ||
| if (counter < 500) { // Record 500 oldest RITs |
There was a problem hiding this comment.
Just in case cluster is already facing some perf issues, we might want to reduce this count. Let's make this configurable.
| metrics.updateRITCount(ritStat.getTotalRITs()); | ||
| metrics.updateRITCountOverThreshold(ritStat.getTotalRITsOverThreshold()); | ||
| if ((EnvironmentEdgeManager.currentTime() - ritStat.ritThreshold / 2) >= ritStat.statTimestamp){ | ||
| LOG.debug("Oldest RIT hashes and states: "+ritStat.getOldestRITHashesAndStates().toString()); |
There was a problem hiding this comment.
Since we are anyways exposing rits in metrics, writing DEBUG logs might be overkill I believe. Let's keep the log at TRACE level?
| } | ||
| } | ||
|
|
||
| public final static RegionStateDurationComparator REGION_STATE_DURATION_COMPARATOR = |
|
@virajjasani @bharathv @apurtell updated this PR to dump to logs only. any more suggestions here? if not I will also update PRs for branch-1 and branch-2. thanks! |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
bharathv
reviewed
Jan 9, 2021
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
We can, if we want only the RITs over threshold logged, and not all the RITs. If that is better I'll update the patch. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
caroliney14
force-pushed
the
HBASE-25329
branch
3 times, most recently
from
4f757b4 to
1ee1775
Compare
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
reviewed
Jan 12, 2021
| update(regionStates.getRegionFailedOpen(), statTimestamp); | ||
|
|
||
| if (ritsOverThreshold != null && !ritsOverThreshold.isEmpty()) { | ||
| LOG.trace("RIT hashes and states: " + |
There was a problem hiding this comment.
Updating logs here looks better. Just small nit: instead of appending string, can we use placeholder {} here?
LOG.trace("RIT hashes and states: {}", val);
… in transition for more than a configured amount of time
caroliney14
force-pushed
the
HBASE-25329
branch
from
1ee1775 to
fcbb912
Compare
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
bharathv
approved these changes
Jan 12, 2021
| update(regionStates.getRegionFailedOpen(), statTimestamp); | ||
|
|
||
| if (ritsOverThreshold != null && !ritsOverThreshold.isEmpty()) { | ||
| LOG.trace("RIT hashes and states: {}", |
There was a problem hiding this comment.
nit: "RITs over threshold...." ? (otherwise it appears these are all the RITs)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@bharathv @virajjasani if this PR looks good, can we merge it? |
|
@caroliney14 Yes good to go unless @virajjasani has any more comments. |
virajjasani
pushed a commit
that referenced
this pull request
Jan 13, 2021
Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
virajjasani
pushed a commit
that referenced
this pull request
Jan 13, 2021
Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
virajjasani
pushed a commit
that referenced
this pull request
Jan 15, 2021
Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
virajjasani
pushed a commit
that referenced
this pull request
Jan 15, 2021
Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
virajjasani
pushed a commit
that referenced
this pull request
Jan 20, 2021
Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
wchevreuil
pushed a commit
to wchevreuil/hbase
that referenced
this pull request
May 24, 2021
Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 6d6b8ec) Change-Id: Iffa49f0dece0bf5d241575fb5827d5a41ea0f7ad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.