HBASE-24121 [Authorization] ServiceAuthorizationManager isn't dynamically updatable. And it should be #1439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ally updatable. And it should be.
|
Using |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
bharathv
requested changes
Apr 6, 2020
| if (scheduler instanceof ConfigurationObserver) { | ||
| ((ConfigurationObserver) scheduler).onConfigurationChange(newConf); | ||
| } | ||
| HBasePolicyProvider.init(newConf, authManager); |
There was a problem hiding this comment.
Regarding thread-safety, do we need to synchronize on authManager while this happens? Otherwise authorize() requests and this init can race and can result in some weird authz results..
|
About the test, the functional test of ServiceAuthorizationManager is done in hadoop-common, and the re-config framework is also testified by many other UTs already. WDYT. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
bharathv
approved these changes
Apr 7, 2020
There was a problem hiding this comment.
About the test, the functional test of ServiceAuthorizationManager is done in hadoop-common, and the re-config framework is also testified by many other UTs already.
I was hoping the unit-test would cover the after-affects of the configuration change. Meaning someone updates the policy.xml with a new policy, the test runs something to make sure the new policy is in affect, something along those lines. Anyway, I'll leave it up to you. Patch looks fine to me.
| if (scheduler instanceof ConfigurationObserver) { | ||
| ((ConfigurationObserver) scheduler).onConfigurationChange(newConf); | ||
| } | ||
| synchronized (authManager) { |
There was a problem hiding this comment.
nit: Add a quick log that we are re-setting the authManager state, probably helps with debugging races later if any..
Yeah, this is what I said, it is exactly about functionality about HDFS's ServiceAuthorizationManager which shouldn't be tested on HBase side. Even if it doesn't take effect, we can do nothing on HBase side (BTW, it does take effect). To me, it is a kind of over-development. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
saintstack
approved these changes
Apr 9, 2020
|
Yes, related. Just pushed a new commit. Waiting QA. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Apr 9, 2020
…ally updatable. And it should be (#1439) Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Michael Stack <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Apr 9, 2020
…ally updatable. And it should be (#1439) Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Michael Stack <[email protected]> Conflicts: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
asfgit
pushed a commit
that referenced
this pull request
Apr 9, 2020
…ally updatable. And it should be (#1439) Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Michael Stack <[email protected]>
|
🎊 +1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Apr 9, 2020
…ally updatable. And it should be (#1439) Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Michael Stack <[email protected]> Conflicts: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
asfgit
pushed a commit
that referenced
this pull request
Apr 9, 2020
…ally updatable. And it should be (#1439) Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Michael Stack <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Apr 9, 2020
…ally updatable. And it should be (#1439) Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Michael Stack <[email protected]> Conflicts: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
thangTang
pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
…ally updatable. And it should be (apache#1439) Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Michael Stack <[email protected]>
thangTang
pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
…ally updatable. And it should be (apache#1439) Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Michael Stack <[email protected]>
thangTang
pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
…ally updatable. And it should be (apache#1439) Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Michael Stack <[email protected]>
Reidddddd
added a commit
to Reidddddd/hbase
that referenced
this pull request
Apr 22, 2020
…ally updatable. And it should be (apache#1439) Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Michael Stack <[email protected]> Conflicts: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
wchevreuil
pushed a commit
to wchevreuil/hbase
that referenced
this pull request
May 24, 2021
…ally updatable. And it should be (apache#1439) Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Michael Stack <[email protected]> Conflicts: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java (cherry picked from commit c99e644) Change-Id: Ic4d1ae5b39d7d562a1b97bf5c4cfe881a283b00e
udaynpusa
pushed a commit
to mapr/hbase
that referenced
this pull request
Jan 30, 2024
…ally updatable. And it should be (apache#1439) Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Michael Stack <[email protected]> Conflicts: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link: HBASE-24121