HBASE-24121 [Authorization] ServiceAuthorizationManager isn't dynamically updatable. And it should be (#1439)

Reidddddd · Reidddddd · commit 8ec886036cd5 · 2020-04-09T17:52:35.000+08:00
Signed-off-by: Bharath Vissapragada &lt;bharathv@apache.org&gt;
Signed-off-by: Michael Stack &lt;stack@apache.org&gt;

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
@@ -2265,6 +2265,14 @@ public void onConfigurationChange(Configuration newConf) {
     if (scheduler instanceof ConfigurationObserver) {
       ((ConfigurationObserver)scheduler).onConfigurationChange(newConf);
     }
+    // Make sure authManager will read hbase-policy file
+    System.setProperty("hadoop.policy.file", "hbase-policy.xml");
+    synchronized (authManager) {
+      authManager.refresh(newConf, new HBasePolicyProvider());
+    }
+    LOG.info("Refreshed hbase-policy.xml successfully");
+    ProxyUsers.refreshSuperUserGroupsConfiguration(newConf);
+    LOG.info("Refreshed super and proxy users successfully");
   }
 
   private void initReconfigurable(Configuration confToLoad) {

Original file line number	Diff line number	Diff line change
`@@ -2265,6 +2265,14 @@ public void onConfigurationChange(Configuration newConf) {`
`2265`	`2265`	`if (scheduler instanceof ConfigurationObserver) {`
`2266`	`2266`	`((ConfigurationObserver)scheduler).onConfigurationChange(newConf);`
`2267`	`2267`	`}`
	`2268`	`+ // Make sure authManager will read hbase-policy file`
	`2269`	`+ System.setProperty("hadoop.policy.file", "hbase-policy.xml");`
	`2270`	`+ synchronized (authManager) {`
	`2271`	`+ authManager.refresh(newConf, new HBasePolicyProvider());`
	`2272`	`+ }`
	`2273`	`+ LOG.info("Refreshed hbase-policy.xml successfully");`
	`2274`	`+ ProxyUsers.refreshSuperUserGroupsConfiguration(newConf);`
	`2275`	`+ LOG.info("Refreshed super and proxy users successfully");`
`2268`	`2276`	`}`
`2269`	`2277`
`2270`	`2278`	`private void initReconfigurable(Configuration confToLoad) {`