HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587 #107

wchevreuil · 2022-06-15T14:35:45Z

No description provided.

Change-Id: Idcd4096f02db3f922d086252b573e64336fd45f1

wchevreuil · 2022-06-15T14:36:38Z

hbase-hbck2/README.md

 Command:
 addFsRegionsMissingInMeta <NAMESPACE|NAMESPACE:TABLENAME>...|-i <INPUT_FILE>...
   Options:
-    -d,--force_disable aborts fix for table if disable fails.


Noticed this option was not being handled in the actual command, so removed it from readme and command helper below.

Makes sense

wchevreuil · 2022-06-15T14:38:37Z

hbase-hbck2/pom.xml

      <artifactId>log4j-api</artifactId>
      <version>${log4j2.version}</version>
+      <scope>provided</scope>
    </dependency>


Whilst testing against a pseudo-distributed 2.6.0-snapshot deployment, was facing conflicts with the slf4j classes shipped in hbck2 jar and the ones loaded from hbase client lib, so marked it as provided to avoid shipping those iin the hbck2 jar.

Will hbck2 be used as a standalone command line tool? If not, then I do not think we need to include these jars.

It could, but we normally run it using the hbase script, so that we get CP built, in which case, shipping slf4j classes within the hbck2 jar was causing below problems to me:

SLF4J: Class path contains multiple SLF4J bindings. SLF4J: Found binding in [jar:file:/root/hbase-3.0.0-alpha-3-SNAPSHOT/hbase-hbck2-1.3.0-SNAPSHOT.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/root/hbase-3.0.0-alpha-3-SNAPSHOT/lib/client-facing-thirdparty/log4j-slf4j-impl-2.17.2.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation. SLF4J: Actual binding is of type [org.apache.logging.slf4j.Log4jLoggerFactory] Exception in thread "main" java.lang.ExceptionInInitializerError Caused by: java.lang.StringIndexOutOfBoundsException: String index out of range: -1 at java.lang.String.substring(String.java:1967) at org.apache.logging.log4j.util.PropertiesUtil.partitionOnCommonPrefixes(PropertiesUtil.java:555) at org.apache.logging.log4j.core.config.properties.PropertiesConfigurationBuilder.build(PropertiesConfigurationBuilder.java:174) at org.apache.logging.log4j.core.config.properties.PropertiesConfigurationFactory.getConfiguration(PropertiesConfigurationFactory.java:56) at org.apache.logging.log4j.core.config.properties.PropertiesConfigurationFactory.getConfiguration(PropertiesConfigurationFactory.java:35) at org.apache.logging.log4j.core.config.ConfigurationFactory$Factory.getConfiguration(ConfigurationFactory.java:557) at org.apache.logging.log4j.core.config.ConfigurationFactory$Factory.getConfiguration(ConfigurationFactory.java:481) at org.apache.logging.log4j.core.config.ConfigurationFactory.getConfiguration(ConfigurationFactory.java:323) at org.apache.logging.log4j.core.LoggerContext.reconfigure(LoggerContext.java:695) at org.apache.logging.log4j.core.LoggerContext.reconfigure(LoggerContext.java:716) at org.apache.logging.log4j.core.LoggerContext.start(LoggerContext.java:270) at org.apache.logging.log4j.core.impl.Log4jContextFactory.getContext(Log4jContextFactory.java:155) at org.apache.logging.log4j.core.impl.Log4jContextFactory.getContext(Log4jContextFactory.java:47) at org.apache.logging.log4j.LogManager.getContext(LogManager.java:196) at org.apache.logging.log4j.spi.AbstractLoggerAdapter.getContext(AbstractLoggerAdapter.java:137) at org.apache.logging.slf4j.Log4jLoggerFactory.getContext(Log4jLoggerFactory.java:55) at org.apache.logging.log4j.spi.AbstractLoggerAdapter.getLogger(AbstractLoggerAdapter.java:47) at org.apache.logging.slf4j.Log4jLoggerFactory.getLogger(Log4jLoggerFactory.java:33) at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:358) at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:383) at org.apache.hbase.HBCK2.<clinit>(HBCK2.java:91)

I think this means we should exclude the log4j related classes in the shaded jar. If we will run it as a standalone command, we should ship the log4j related jars in the final tarball.

Ok, maybe this is a broader issue and we should address in a separate jira, as I noticed the following classpath issues whilst testing it against a pseudo-distributed 2.6.0-SNASPHOT:

If I try run hbck2 as ./bin/hbase hbck -j ../hbase-hbck2-1.3.0-SNAPSHOT.jar, I get below error:

Error: Could not find or load main class org.apache.hbase.HBCK2 Caused by: java.lang.NoClassDefFoundError: org/apache/hadoop/util/Tool

If I try run the hbck2 jar that includes slf4j classes as ./bin/hbase --internal-classpath hbck -j ../hbase-hbck2-1.3.0-SNAPSHOT.jar, it passes the NCDFE mentioned above, but it then gets the error from my previous comment. So maybe this slf4j conflict is due to this --internal-classpath flag that shouldn't be used. e

Apache-HBase · 2022-06-15T14:54:25Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 4s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	markdownlint	0m 0s	markdownlint was not available.
+0 🆗	spotbugs	0m 0s	spotbugs executables are not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	0m 54s	master passed
+1 💚	compile	0m 9s	master passed
+1 💚	checkstyle	0m 7s	master passed
+1 💚	javadoc	0m 7s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 10s	the patch passed
+1 💚	compile	0m 9s	the patch passed
+1 💚	javac	0m 9s	the patch passed
-1 ❌	checkstyle	0m 4s	hbase-hbck2: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 0s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 5s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 47s	hbase-hbck2 in the patch passed.
+1 💚	asflicense	0m 6s	The patch does not generate ASF License warnings.
		6m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-107/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#107
Optional Tests	dupname asflicense markdownlint javac javadoc unit xml compile spotbugs findbugs checkstyle
uname	Linux d86160749c11 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 GNU/Linux
Build tool	maven
git revision	master / `6f0796f`
Default Java	Oracle Corporation-1.8.0_282-b08
checkstyle	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-107/1/artifact/yetus-precommit-check/output/diff-checkstyle-hbase-hbck2.txt
Test Results	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-107/1/testReport/
Max. process+thread count	1252 (vs. ulimit of 5000)
modules	C: hbase-hbck2 U: hbase-hbck2
Console output	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-107/1/console
versions	git=2.20.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9

Mind explaining a bit on what is the problem here? After skimming the PR, I can not fully understand what is the problem we are trying to fix here...

Apache9 · 2022-06-15T15:13:38Z

hbase-hbck2/pom.xml

      <artifactId>log4j-api</artifactId>
      <version>${log4j2.version}</version>
+      <scope>provided</scope>
    </dependency>


Will hbck2 be used as a standalone command line tool? If not, then I do not think we need to include these jars.

wchevreuil · 2022-06-16T09:36:11Z

Mind explaining a bit on what is the problem here? After skimming the PR, I can not fully understand what is the problem we are trying to fix here...

HBCK2 replication and filesystem commands are broken after HBASE-24587. Trying to pass the f or -fix options give the below error:

ERROR: Unrecognized option: -f
FOR USAGE, use the -h or --help option
2022-06-14T16:07:32,296 INFO  [main] client.ConnectionImplementation: Closing master protocol: MasterService
Exception in thread "main" java.lang.NullPointerException
	at org.apache.hbase.HBCK2.doCommandLine(HBCK2.java:1083)
	at org.apache.hbase.HBCK2.run(HBCK2.java:982)
	at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
	at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90)
	at org.apache.hbase.HBCK2.main(HBCK2.java:1318)

This is because getInputList calls here and here only accept the -i/--inputFiles options, throwing an exception if we pass -f/--fix options.

ndimiduk · 2022-06-16T10:21:38Z

FYI @clarax

Apache9

OK, I can partly know what is the problem now, but the whole implementation seems a mess to me...

Why don't create an Options for each command separately? And then parse it? Because most command share almost the same pattern?

hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java

Change-Id: Ic8156b9f0c2ecefc3abc3dacdf0829e7a23f58a0

wchevreuil · 2022-06-16T14:33:37Z

OK, I can partly know what is the problem now, but the whole implementation seems a mess to me...

I'm happy to answer any questions you might still have. If you feel confused because of the extra pom, readme and command help changes which are not related to the issue's title here, I can revert those and put in extra PR's.

Why don't create an Options for each command separately? And then parse it? Because most command share almost the same pattern?

Originally thought about that, but then decided better to do the parsing once.

Change-Id: I772e05f6f283f939d3d0ba3de2e13cbdc6bb3910

Apache-HBase · 2022-06-16T14:35:34Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	markdownlint	0m 0s	markdownlint was not available.
+0 🆗	spotbugs	0m 0s	spotbugs executables are not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	0m 51s	master passed
+1 💚	compile	0m 9s	master passed
+1 💚	checkstyle	0m 7s	master passed
+1 💚	javadoc	0m 7s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 11s	the patch passed
+1 💚	compile	0m 9s	the patch passed
+1 💚	javac	0m 9s	the patch passed
+1 💚	checkstyle	0m 4s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 5s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 46s	hbase-hbck2 in the patch passed.
+1 💚	asflicense	0m 6s	The patch does not generate ASF License warnings.
		6m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-107/2/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#107
Optional Tests	dupname asflicense markdownlint javac javadoc unit xml compile spotbugs findbugs checkstyle
uname	Linux 5845784a964e 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 GNU/Linux
Build tool	maven
git revision	master / `bd0fe94`
Default Java	Oracle Corporation-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-107/2/testReport/
Max. process+thread count	1251 (vs. ulimit of 5000)
modules	C: hbase-hbck2 U: hbase-hbck2
Console output	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-107/2/console
versions	git=2.20.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-06-16T14:55:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	markdownlint	0m 0s	markdownlint was not available.
+0 🆗	spotbugs	0m 0s	spotbugs executables are not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	0m 54s	master passed
+1 💚	compile	0m 9s	master passed
+1 💚	checkstyle	0m 7s	master passed
+1 💚	javadoc	0m 7s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 11s	the patch passed
+1 💚	compile	0m 9s	the patch passed
+1 💚	javac	0m 9s	the patch passed
+1 💚	checkstyle	0m 4s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 5s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 49s	hbase-hbck2 in the patch passed.
+1 💚	asflicense	0m 6s	The patch does not generate ASF License warnings.
		6m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-107/3/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#107
Optional Tests	dupname asflicense markdownlint javac javadoc unit xml compile spotbugs findbugs checkstyle
uname	Linux 7469b8cd0a33 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 GNU/Linux
Build tool	maven
git revision	master / `bd0fe94`
Default Java	Oracle Corporation-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-107/3/testReport/
Max. process+thread count	1292 (vs. ulimit of 5000)
modules	C: hbase-hbck2 U: hbase-hbck2
Console output	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-107/3/console
versions	git=2.20.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

clarax · 2022-06-16T19:08:02Z

Thanks a lot for adding the comprehensive UT. Please see an alternative fix that follows the same pattern for other commands with command options. #109

clarax · 2022-06-16T23:15:13Z

LGTM. See conversation at #109.

Change-Id: Ibed1b7b741216082e8b6d542ccaa5f595af40dd9

Apache-HBase · 2022-06-20T13:43:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	markdownlint	0m 0s	markdownlint was not available.
+0 🆗	spotbugs	0m 1s	spotbugs executables are not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	0m 48s	master passed
+1 💚	compile	0m 9s	master passed
+1 💚	checkstyle	0m 7s	master passed
+1 💚	javadoc	0m 8s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 11s	the patch passed
+1 💚	compile	0m 9s	the patch passed
+1 💚	javac	0m 9s	the patch passed
+1 💚	checkstyle	0m 4s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 0s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 5s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 45s	hbase-hbck2 in the patch passed.
+1 💚	asflicense	0m 6s	The patch does not generate ASF License warnings.
		6m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-107/4/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#107
Optional Tests	dupname asflicense markdownlint javac javadoc unit xml compile spotbugs findbugs checkstyle
uname	Linux 64040fa6032d 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 GNU/Linux
Build tool	maven
git revision	master / `bd0fe94`
Default Java	Oracle Corporation-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-107/4/testReport/
Max. process+thread count	1248 (vs. ulimit of 5000)
modules	C: hbase-hbck2 U: hbase-hbck2
Console output	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-107/4/console
versions	git=2.20.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

hbase-hbck2/src/test/java/org/apache/hbase/TestHBCKCommandLineParsing.java

Change-Id: Ic233deec2307474549f111b5b881dca7454c6256

Change-Id: I5795a4924c83576cf7a2bb70cc760470d0ff01d0

wchevreuil · 2022-06-21T11:05:17Z

Thanks for the review, @petersomogyi . Had applied your suggestions.

Apache-HBase · 2022-06-21T11:09:49Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	markdownlint	0m 0s	markdownlint was not available.
+0 🆗	spotbugs	0m 0s	spotbugs executables are not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	0m 50s	master passed
+1 💚	compile	0m 9s	master passed
+1 💚	checkstyle	0m 6s	master passed
+1 💚	javadoc	0m 7s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 11s	the patch passed
+1 💚	compile	0m 9s	the patch passed
+1 💚	javac	0m 9s	the patch passed
-1 ❌	checkstyle	0m 4s	hbase-hbck2: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 5s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 51s	hbase-hbck2 in the patch passed.
+1 💚	asflicense	0m 6s	The patch does not generate ASF License warnings.
		6m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-107/5/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#107
Optional Tests	dupname asflicense markdownlint javac javadoc unit xml compile spotbugs findbugs checkstyle
uname	Linux 13fe1e3b53ea 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 GNU/Linux
Build tool	maven
git revision	master / `bd0fe94`
Default Java	Oracle Corporation-1.8.0_282-b08
checkstyle	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-107/5/artifact/yetus-precommit-check/output/diff-checkstyle-hbase-hbck2.txt
Test Results	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-107/5/testReport/
Max. process+thread count	1234 (vs. ulimit of 5000)
modules	C: hbase-hbck2 U: hbase-hbck2
Console output	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-107/5/console
versions	git=2.20.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-06-21T11:26:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	markdownlint	0m 0s	markdownlint was not available.
+0 🆗	spotbugs	0m 0s	spotbugs executables are not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	2m 46s	master passed
+1 💚	compile	0m 9s	master passed
+1 💚	checkstyle	0m 7s	master passed
+1 💚	javadoc	0m 7s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 11s	the patch passed
+1 💚	compile	0m 9s	the patch passed
+1 💚	javac	0m 9s	the patch passed
-1 ❌	checkstyle	0m 4s	hbase-hbck2: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 0s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 6s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 46s	hbase-hbck2 in the patch passed.
+1 💚	asflicense	0m 5s	The patch does not generate ASF License warnings.
		8m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-107/6/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#107
Optional Tests	dupname asflicense markdownlint javac javadoc unit xml compile spotbugs findbugs checkstyle
uname	Linux 47a469cd61c6 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 GNU/Linux
Build tool	maven
git revision	master / `bd0fe94`
Default Java	Oracle Corporation-1.8.0_282-b08
checkstyle	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-107/6/artifact/yetus-precommit-check/output/diff-checkstyle-hbase-hbck2.txt
Test Results	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-107/6/testReport/
Max. process+thread count	1247 (vs. ulimit of 5000)
modules	C: hbase-hbck2 U: hbase-hbck2
Console output	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-107/6/console
versions	git=2.20.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

petersomogyi

Thanks @wchevreuil! Please fix the checkstyle warning before committing.

Change-Id: If88d15e3940db754eb178070be8444d5caf677cd

Apache-HBase · 2022-06-21T15:24:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	markdownlint	0m 0s	markdownlint was not available.
+0 🆗	spotbugs	0m 0s	spotbugs executables are not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	0m 49s	master passed
+1 💚	compile	0m 10s	master passed
+1 💚	checkstyle	0m 6s	master passed
+1 💚	javadoc	0m 7s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 10s	the patch passed
+1 💚	compile	0m 9s	the patch passed
+1 💚	javac	0m 9s	the patch passed
+1 💚	checkstyle	0m 4s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 5s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 46s	hbase-hbck2 in the patch passed.
+1 💚	asflicense	0m 5s	The patch does not generate ASF License warnings.
		6m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-107/7/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#107
Optional Tests	dupname asflicense markdownlint javac javadoc unit xml compile spotbugs findbugs checkstyle
uname	Linux ab19a58cd19c 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 GNU/Linux
Build tool	maven
git revision	master / `bd0fe94`
Default Java	Oracle Corporation-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-107/7/testReport/
Max. process+thread count	1268 (vs. ulimit of 5000)
modules	C: hbase-hbck2 U: hbase-hbck2
Console output	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-107/7/console
versions	git=2.20.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587

5d3acdb

Change-Id: Idcd4096f02db3f922d086252b573e64336fd45f1

wchevreuil requested review from Apache9, joshelser, ndimiduk and petersomogyi June 15, 2022 14:35

wchevreuil commented Jun 15, 2022

View reviewed changes

Apache9 reviewed Jun 15, 2022

View reviewed changes

Apache9 reviewed Jun 16, 2022

View reviewed changes

hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java Outdated Show resolved Hide resolved

addressing checkstyles

abdff4e

Change-Id: Ic8156b9f0c2ecefc3abc3dacdf0829e7a23f58a0

addressing review comments

670e23c

Change-Id: I772e05f6f283f939d3d0ba3de2e13cbdc6bb3910

clarax mentioned this pull request Jun 16, 2022

HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587 #109

Closed

reverting pom changes, will deal with this issue on another ticket

f0810b0

Change-Id: Ibed1b7b741216082e8b6d542ccaa5f595af40dd9

petersomogyi reviewed Jun 20, 2022

View reviewed changes

hbase-hbck2/src/test/java/org/apache/hbase/TestHBCKCommandLineParsing.java Outdated Show resolved Hide resolved

hbase-hbck2/src/test/java/org/apache/hbase/TestHBCKCommandLineParsing.java Outdated Show resolved Hide resolved

wchevreuil added 2 commits June 21, 2022 12:01

addressing Peter's review comments

0db69a5

Change-Id: Ic233deec2307474549f111b5b881dca7454c6256

addressing Peter's review comments

844be15

Change-Id: I5795a4924c83576cf7a2bb70cc760470d0ff01d0

wchevreuil requested a review from petersomogyi June 21, 2022 11:04

petersomogyi approved these changes Jun 21, 2022

View reviewed changes

addressing checkstyles

a636aa2

Change-Id: If88d15e3940db754eb178070be8444d5caf677cd

petersomogyi approved these changes Jun 21, 2022

View reviewed changes

wchevreuil merged commit 7b21879 into apache:master Jun 21, 2022

This was referenced May 4, 2023

HBASE-27829 Introduce build for kuttl image, basis for dev/test environment #118

Closed

HBASE-27830 Introduce hdfs overlay #120

Closed

HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587 #107

HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587 #107

Uh oh!

Conversation

wchevreuil commented Jun 15, 2022

Uh oh!

wchevreuil Jun 15, 2022

Choose a reason for hiding this comment

Uh oh!

clarax Jun 16, 2022

Choose a reason for hiding this comment

Uh oh!

wchevreuil Jun 15, 2022

Choose a reason for hiding this comment

Uh oh!

Apache9 Jun 15, 2022

Choose a reason for hiding this comment

Uh oh!

wchevreuil Jun 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Apache9 Jun 16, 2022

Choose a reason for hiding this comment

Uh oh!

wchevreuil Jun 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Jun 15, 2022

Uh oh!

Apache9 left a comment

Choose a reason for hiding this comment

Uh oh!

Apache9 Jun 15, 2022

Choose a reason for hiding this comment

Uh oh!

wchevreuil commented Jun 16, 2022

Uh oh!

ndimiduk commented Jun 16, 2022

Uh oh!

Apache9 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wchevreuil commented Jun 16, 2022

Uh oh!

Apache-HBase commented Jun 16, 2022

Uh oh!

Apache-HBase commented Jun 16, 2022

Uh oh!

clarax commented Jun 16, 2022

Uh oh!

clarax commented Jun 16, 2022

Uh oh!

Apache-HBase commented Jun 20, 2022

Uh oh!

Uh oh!

Uh oh!

wchevreuil commented Jun 21, 2022

Uh oh!

Apache-HBase commented Jun 21, 2022

Uh oh!

Apache-HBase commented Jun 21, 2022

Uh oh!

petersomogyi left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Jun 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

wchevreuil Jun 16, 2022 •

edited

Loading

wchevreuil Jun 16, 2022 •

edited

Loading