HBASE-27829 Introduce build for `kuttl` image, basis for dev/test environment #118

ndimiduk · 2023-05-04T13:39:52Z

No description provided.

ndimiduk · 2023-05-04T13:41:00Z

First commit is #117 as a dependency.

ndimiduk · 2023-05-16T16:21:51Z

hbase-kubernetes-deployment/hbase-kubernetes-testing-image/pom.xml

+    <plugins>
+      <plugin>
+        <groupId>org.codehaus.mojo</groupId>
+        <artifactId>exec-maven-plugin</artifactId>


The best alternative I can find to using exec:exec is the docker-maven-plugin. It has some nice features but ultimately also requires having docker installed on the build host and makes it more difficult to execute the image build from native docker tools.

petersomogyi

I was able to build it based on the readme (minor comments below). 🎉
The change looks fine to me but I don't have a lot of k8s or kuttl experience.

hbase-kubernetes-deployment/hbase-kubernetes-testing-image/README.md

petersomogyi · 2023-05-31T12:31:32Z

...ubernetes-deployment/hbase-kubernetes-testing-image/src/main/docker/docker-bake.override.hcl

+}
+
+variable KUSTOMIZE_VERSION {
+  default = "4.5.4"


There is a new kustomize v5.0.3. We might consider moving to that one later.

The version of the kustomize executable is tied to the version of kustomize that is used as a dependency by the version of kubectl that is packaged. We can upgrade them but they must stay in sync.

FYI, the version of the kubectl executable is coupled to the version of kubernetes that is targeted. There's a limited range of kubernetes version supported by a given kubectl version. Right now, the target kubernetes version in the dockerfile is ENVTEST_K8S_VERSION='1.23.x'.

hbase-kubernetes-deployment/hbase-kubernetes-testing-image/README.md

hbase-kubernetes-deployment/hbase-kubernetes-testing-image/src/main/docker/Dockerfile

ndimiduk · 2023-06-01T11:16:37Z

...ubernetes-deployment/hbase-kubernetes-testing-image/src/main/docker/docker-bake.override.hcl

+}
+
+variable KUSTOMIZE_VERSION {
+  default = "4.5.4"


The version of the kustomize executable is tied to the version of kustomize that is used as a dependency by the version of kubectl that is packaged. We can upgrade them but they must stay in sync.

FYI, the version of the kubectl executable is coupled to the version of kubernetes that is targeted. There's a limited range of kubernetes version supported by a given kubectl version. Right now, the target kubernetes version in the dockerfile is ENVTEST_K8S_VERSION='1.23.x'.

…ironment Drive kuttl image build from maven. Use maven exec plugin to call `docker buildx bake` as part of the module `package` phase. Allow it all to run from within Docker-in-Docker via Yetus.

Apache-HBase · 2023-06-01T12:08:31Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-118/17/console in case of problems.

Apache-HBase · 2023-06-01T12:21:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 14s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	shelldocs	0m 0s	Shelldocs was not available.
+0 🆗	markdownlint	0m 0s	markdownlint was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ HBASE-27827-kubernetes-deployment Compile Tests _
+0 🆗	mvndep	0m 24s	Maven dependency ordering for branch
+1 💚	mvninstall	0m 27s	HBASE-27827-kubernetes-deployment passed
+1 💚	compile	0m 15s	HBASE-27827-kubernetes-deployment passed
+1 💚	javadoc	0m 12s	HBASE-27827-kubernetes-deployment passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 6s	Maven dependency ordering for patch
+1 💚	mvninstall	1m 30s	the patch passed
+1 💚	compile	0m 20s	the patch passed
+1 💚	javac	0m 20s	the patch passed
+1 💚	hadolint	0m 1s	There were no new hadolint issues.
+1 💚	shellcheck	0m 0s	There were no new shellcheck issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 5s	hbase-kubernetes-deployment in the patch passed.
+1 💚	unit	6m 15s	root in the patch passed.
+1 💚	unit	0m 4s	hbase-kubernetes-testing-image in the patch passed.
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		12m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-118/17/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#118
Optional Tests	dupname asflicense hadolint shellcheck shelldocs markdownlint javac javadoc unit xml compile
uname	Linux e602f8f1be5d 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 GNU/Linux
Build tool	maven
git revision	HBASE-27827-kubernetes-deployment / `f521479`
Default Java	Oracle Corporation-1.8.0_342-b07
Test Results	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-118/17/testReport/
Max. process+thread count	1265 (vs. ulimit of 5000)
modules	C: hbase-kubernetes-deployment . hbase-kubernetes-deployment/hbase-kubernetes-testing-image U: .
Console output	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-118/17/console
versions	git=2.30.2 maven=3.8.6 shellcheck=0.7.1 hadolint=Haskell Dockerfile Linter 2.12.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk · 2023-06-16T09:11:08Z

Superseded by apache/hbase-kustomize#3