-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-19680. Update non-thirdparty Guava version to 32.0.1 #7940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
same as the current thirdparty Guava version
💔 -1 overall
This message was automatically generated. |
cc @cnauroth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 Thank you @stoty . I'm good with this change. Ideally, I would like to see at least one more committer +1, just in case there are some downstream impacts I haven't thought of.
CC: @steveloughran , @ayushtkn , @mukund-thakur
@cnauroth Thanks for the review! I think we still need to carefully consider this change and should wait for Steve's confirmation before making a decision. cc: @steveloughran |
For what it's worth: I've fought a LOT with guava versions in the last six years, but I haven't seen any issue (apart from Google adding new annotation libraries which throw off some shading tests) when upgrading from 27 to a newer version. |
I've been away. let's do it an update in release notes that you can change the version without breaking any hadoop code. |
Thanks @steveloughran . |
thanks...your release note is good, added something in the commit too. can you do a backport PR to branch-3.4; I think we should be looking at a "dependency update" release there with minimal actual code changes |
Thanks @steveloughran . |
same as the current thirdparty Guava version
Description of PR
Guava has been already updated to 32.0.1 in hadoop-thirdparty.
However, Hadoop also dependency manages the non-thirdparty guava version (coming from dependencies), which is still at 27.0-jre , showing up on static scanners.
Sync the non-thirdparty Guava version to the thirdparty one.
How was this patch tested?
Test suite in CI (on this PR)
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?