Skip to content

HDFS-17378: Add missing operationType for some operations in authorizer #6553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

HDFS-17378: Add missing operationType for some operations in authorizer #6553

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cb6f585
HDFS-17378. Add missing operationType for some operations in authorizer
sbernauer Feb 9, 2024
d68e060
Trigger ci
sbernauer Feb 26, 2024
8b12771
Merge remote-tracking branch 'origin/trunk' into fix/HDFS-17378-add-m…
sbernauer Oct 1, 2025
09d7c02
Remove now unneeded operationNames
sbernauer Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...roject/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2759,6 +2759,7 @@ private HdfsFileStatus startFileInt(String src,
long blockSize, CryptoProtocolVersion[] supportedVersions,
String ecPolicyName, String storagePolicy, boolean logRetryCache)
throws IOException {
final String operationName = "create";
if (NameNode.stateChangeLog.isDebugEnabled()) {
StringBuilder builder = new StringBuilder();
builder.append("DIR* NameSystem.startFile: src=").append(src)
Expand Down Expand Up @@ -2796,6 +2797,7 @@ private HdfsFileStatus startFileInt(String src,

checkOperation(OperationCategory.WRITE);
final FSPermissionChecker pc = getPermissionChecker();
FSPermissionChecker.setOperationType(operationName);
writeLock(RwLockMode.FS);
try {
checkOperation(OperationCategory.WRITE);
Expand Down Expand Up @@ -2858,7 +2860,7 @@ private HdfsFileStatus startFileInt(String src,
dir.writeUnlock();
}
} finally {
writeUnlock(RwLockMode.FS, "create",
writeUnlock(RwLockMode.FS, operationName,
getLockReportInfoSupplier(src, null, stat));
// There might be transactions logged while trying to recover the lease.
// They need to be sync'ed even when an exception was thrown.
Expand Down Expand Up @@ -3255,7 +3257,7 @@ INodeFile checkLease(INodesInPath iip, String holder, long fileId)
*/
boolean completeFile(final String src, String holder,
ExtendedBlock last, long fileId)
throws IOException {
throws IOException {
boolean success = false;
final String operationName = "completeFile";
checkOperation(OperationCategory.WRITE);
Expand Down