You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are writing a custom authorizer that only supports the new checkPermissionWithContext API (as we want to have access to the operationName).
Previously the old API was called, now only the new API will be called.
For code changes:
Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?
CC @jojochuang, as you originally implemented the new API
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚
mvninstall
33m 1s
trunk passed
+1 💚
compile
0m 42s
trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚
compile
0m 39s
trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚
checkstyle
0m 37s
trunk passed
+1 💚
mvnsite
0m 45s
trunk passed
+1 💚
javadoc
0m 40s
trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚
javadoc
1m 2s
trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚
spotbugs
1m 44s
trunk passed
+1 💚
shadedclient
20m 38s
branch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚
mvninstall
32m 50s
trunk passed
+1 💚
compile
0m 42s
trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚
compile
0m 40s
trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚
checkstyle
0m 39s
trunk passed
+1 💚
mvnsite
0m 47s
trunk passed
+1 💚
javadoc
0m 41s
trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚
javadoc
1m 4s
trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚
spotbugs
1m 43s
trunk passed
+1 💚
shadedclient
20m 7s
branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚
mvninstall
0m 36s
the patch passed
+1 💚
compile
0m 37s
the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚
javac
0m 37s
the patch passed
+1 💚
compile
0m 38s
the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚
javac
0m 38s
the patch passed
+1 💚
blanks
0m 0s
The patch has no blanks issues.
+1 💚
checkstyle
0m 30s
hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 109 unchanged - 1 fixed = 109 total (was 110)
+1 💚
mvnsite
0m 38s
the patch passed
+1 💚
javadoc
0m 30s
the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚
javadoc
0m 59s
the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚
spotbugs
1m 44s
the patch passed
+1 💚
shadedclient
20m 23s
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚
mvninstall
86m 20s
trunk passed
+1 💚
compile
5m 53s
trunk passed
+1 💚
checkstyle
4m 32s
trunk passed
+1 💚
mvnsite
6m 12s
trunk passed
+1 💚
javadoc
5m 39s
trunk passed
+1 💚
shadedclient
140m 10s
branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚
mvninstall
4m 23s
the patch passed
+1 💚
compile
3m 26s
the patch passed
+1 💚
javac
3m 26s
the patch passed
+1 💚
blanks
0m 01s
The patch has no blanks issues.
+1 💚
checkstyle
2m 14s
the patch passed
+1 💚
mvnsite
3m 52s
the patch passed
+1 💚
javadoc
3m 21s
the patch passed
+1 💚
shadedclient
150m 58s
patch has no errors when building and testing our client artifacts.
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open it and ask for a committer to remove the stale tag and review again.
Thanks all for your contribution.
It looks like #6776 fixed the bug (it was raised afterwards but reviewed and merged before).
The patches are slight different (e.g. this patch avoids duplicating constants such as "create"), but reading through the other PR and my first commit on this PR it looks like all missing operations have been added.
sbernauer
changed the title
HDFS-17378. Add missing operationType for some operations in authorizer
HDFS-17378: Add missing operationType for some operations in authorizer
Oct 1, 2025
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
See Issue description
How was this patch tested?
We are writing a custom authorizer that only supports the new
checkPermissionWithContext
API (as we want to have access to theoperationName
).Previously the old API was called, now only the new API will be called.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?CC @jojochuang, as you originally implemented the new API