Skip to content

Conversation

@hotcodemacha
Copy link
Contributor

Description of PR

Upgrade jquery ui to 1.13.2 to mitigate CVE-2022-31160

JIRA - YARN-11303

How was this patch tested?

Verified on UI

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hotcodemacha
Copy link
Contributor Author

hotcodemacha commented Sep 16, 2022

I build it with the patch and the UI seems to working fine. Attaching screenshot for reference.

Screenshot 2022-09-16 at 06 35 34

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 50s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 xmllint 0m 1s xmllint was not available.
+0 🆗 jshint 0m 1s jshint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 38m 15s trunk passed
+1 💚 compile 1m 1s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 compile 0m 50s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 checkstyle 0m 52s trunk passed
+1 💚 mvnsite 1m 6s trunk passed
+1 💚 javadoc 1m 2s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 52s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 1m 56s trunk passed
+1 💚 shadedclient 21m 42s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 44s the patch passed
+1 💚 compile 0m 47s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 javac 0m 47s the patch passed
+1 💚 compile 0m 40s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 javac 0m 40s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 30s the patch passed
+1 💚 mvnsite 0m 44s the patch passed
+1 💚 javadoc 0m 40s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 44s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 1m 52s the patch passed
+1 💚 shadedclient 22m 40s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 5m 11s hadoop-yarn-common in the patch passed.
+1 💚 asflicense 0m 44s The patch does not generate ASF License warnings.
103m 58s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4895/1/artifact/out/Dockerfile
GITHUB PR #4895
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle jshint
uname Linux 18e5fda78630 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 189ba4d
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4895/1/testReport/
Max. process+thread count 681 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4895/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri
Copy link
Member

goiri commented Sep 20, 2022

Can we get a clean build?

@hotcodemacha
Copy link
Contributor Author

Thanks @goiri for reviewing and approving. We do that have a clean build except the following and I hope it should be fine for this PR.

-1 ❌ | test4tests | 0m  0s |   | The patch doesn't appear to include any new or  modified tests. Please justify why no new tests are needed for this  patch. Also please list what manual steps were performed to verify this  patch.
-- | -- | -- | -- | --

Also please list what manual steps were performed to verify this patch.

Further I have manually tested and attached the screenshot as well for reference.

@goiri goiri merged commit a134628 into apache:trunk Sep 20, 2022
@hotcodemacha
Copy link
Contributor Author

Thanks @goiri for reviewing and merging.

@hotcodemacha hotcodemacha deleted the YARN-11303 branch September 21, 2022 03:58
hotcodemacha added a commit to hotcodemacha/hadoop that referenced this pull request Sep 23, 2022
steveloughran pushed a commit that referenced this pull request Oct 5, 2022
asfgit pushed a commit that referenced this pull request Oct 5, 2022
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
senthh pushed a commit to acceldata-io/hadoop that referenced this pull request Sep 11, 2024
shubhluck pushed a commit to acceldata-io/hadoop that referenced this pull request Sep 11, 2024
… jquery (#19)

* YARN-11092. Upgrade jquery ui to 1.13.1 (apache#4260)

Co-authored-by: Ashutosh Gupta <[email protected]>
Signed-off-by: Akira Ajisaka <[email protected]>
(cherry picked from commit 931abbd)

 Conflicts:
	hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/JQueryUI.java

Change-Id: I5d5f729aa0c778298d753ff5400b33b5e95edd5d

* ODP-2215 - importing com.google.common.collect.Lists

* YARN-11303. Upgrade jquery ui to 1.13.2 to mitigate CVE-2022-31160 (apache#4895)


Contributed by Ashutosh Gupta

* HADOOP-18044. Hadoop - Upgrade to jQuery 3.6.0 (apache#3791)

Co-authored-by: luoyuan <[email protected]>
(cherry picked from commit e2d6201)

* ODP-2215 - Deleting  jquery-3.3.1.min.js

---------

Co-authored-by: Ashutosh Gupta <[email protected]>
Co-authored-by: luoyuan3471 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants