Skip to content

Conversation

@luoyuan3471
Copy link
Contributor

jQuery 3.6.0 has been released few months ago - http://blog.jquery.com/2021/03/02/jquery-3-6-0-released/

We can upgrade jquery-3.5.1.min.js to jquery-3.6.0.min.js in hadoop project.

@brahmareddybattula
Copy link
Contributor

@luoyuan3471 thanks for reporting.. Did you get chance verify with version..? It'll be good if you can verify and update the status.

@luoyuan3471
Copy link
Contributor Author

@brahmareddybattula Thanks for your reply. In our YARN cluster contains thousands of nodes, we upgraded jquery version from 3.5.1->3.6.0. It has been running for more than a month and no problems have been found.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 44m 51s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 shellcheck 0m 0s Shellcheck was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+0 🆗 jshint 0m 0s jshint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 12m 32s Maven dependency ordering for branch
+1 💚 mvninstall 25m 21s trunk passed
+1 💚 compile 20m 51s trunk passed
+1 💚 checkstyle 4m 3s trunk passed
+1 💚 mvnsite 27m 4s trunk passed
+1 💚 javadoc 8m 42s trunk passed
+1 💚 spotbugs 41m 58s trunk passed
+1 💚 shadedclient 57m 58s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 24s Maven dependency ordering for patch
+1 💚 mvninstall 27m 40s the patch passed
+1 💚 compile 20m 16s the patch passed
+1 💚 javac 20m 16s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 3m 54s the patch passed
+1 💚 mvnsite 26m 11s the patch passed
+1 💚 xml 0m 4s The patch has no ill-formed XML file.
+1 💚 javadoc 9m 12s the patch passed
+1 💚 spotbugs 42m 59s the patch passed
+1 💚 shadedclient 58m 14s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 1039m 33s /patch-unit-root.txt root in the patch passed.
+1 💚 asflicense 1m 45s The patch does not generate ASF License warnings.
1406m 17s
Reason Tests
Failed junit tests hadoop.hdfs.rbfbalance.TestRouterDistCpProcedure
hadoop.hdfs.server.federation.router.TestRouterRPCMultipleDestinationMountTableResolver
hadoop.hdfs.server.diskbalancer.command.TestDiskBalancerCommand
hadoop.tools.dynamometer.TestDynamometerInfra
hadoop.yarn.csi.client.TestCsiClient
hadoop.ipc.TestIPC
hadoop.crypto.TestCryptoStreamsWithOpensslSm4CtrCryptoCodec
hadoop.crypto.TestCryptoCodec
hadoop.service.launcher.TestServiceInterruptHandling
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3791/2/artifact/out/Dockerfile
GITHUB PR #3791
Optional Tests dupname asflicense codespell shellcheck shelldocs shadedclient compile javac javadoc mvninstall mvnsite unit xml jshint spotbugs checkstyle
uname Linux 8fae8b6cfd9e 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 88552f2
Default Java Red Hat, Inc.-1.8.0_312-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3791/2/testReport/
Max. process+thread count 2256 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-hdfs-project/hadoop-hdfs-rbf . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3791/2/console
versions git=2.9.5 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@jojochuang jojochuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at PR #2330 and #2340, this is all we need assuming no backward incompatible changes in jQuery itself.

@luoyuan3471
Copy link
Contributor Author

Any concern about this PR?

@jojochuang jojochuang merged commit e2d6201 into apache:trunk Jan 12, 2022
@jojochuang
Copy link
Contributor

Merged to trunk. I think we can have this in the next 3.3.x release, which is 3.3.3.

@brahmareddybattula
Copy link
Contributor

@jojochuang Can we merge this other branches also..? Specifically for branch-3.2.3 also..?

asfgit pushed a commit that referenced this pull request Feb 11, 2022
Co-authored-by: luoyuan <[email protected]>
(cherry picked from commit e2d6201)
@jojochuang
Copy link
Contributor

The commit applies cleanly against branch-3.3. branch-3.2 has some conflicts because the jQuery 3.5.1 updates were not cherrypicked to branch-3.2. So you'd need to backport them too (not clean).

steveloughran pushed a commit to steveloughran/hadoop that referenced this pull request Jun 23, 2022
steveloughran added a commit that referenced this pull request Jun 23, 2022
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
)

Co-authored-by: luoyuan <[email protected]>

# Conflicts:
#	LICENSE-binary
#	LICENSE.txt
#	hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/webapps/router/explorer.html
#	hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html
#	hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/journal/journalnode.html

Change-Id: I6719e2986272282be01cb898530be8c80dd845d2
senthh pushed a commit to acceldata-io/hadoop that referenced this pull request Sep 11, 2024
shubhluck pushed a commit to acceldata-io/hadoop that referenced this pull request Sep 11, 2024
… jquery (#19)

* YARN-11092. Upgrade jquery ui to 1.13.1 (apache#4260)

Co-authored-by: Ashutosh Gupta <[email protected]>
Signed-off-by: Akira Ajisaka <[email protected]>
(cherry picked from commit 931abbd)

 Conflicts:
	hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/JQueryUI.java

Change-Id: I5d5f729aa0c778298d753ff5400b33b5e95edd5d

* ODP-2215 - importing com.google.common.collect.Lists

* YARN-11303. Upgrade jquery ui to 1.13.2 to mitigate CVE-2022-31160 (apache#4895)


Contributed by Ashutosh Gupta

* HADOOP-18044. Hadoop - Upgrade to jQuery 3.6.0 (apache#3791)

Co-authored-by: luoyuan <[email protected]>
(cherry picked from commit e2d6201)

* ODP-2215 - Deleting  jquery-3.3.1.min.js

---------

Co-authored-by: Ashutosh Gupta <[email protected]>
Co-authored-by: luoyuan3471 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants