Skip to content

HDDS-2257. Fix checkstyle issues in ChecksumByteBuffer #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2019
Merged

HDDS-2257. Fix checkstyle issues in ChecksumByteBuffer #1603

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/common/ChecksumByteBuffer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ default void update(byte[] b, int off, int len) {
* An abstract class implementing {@link ChecksumByteBuffer}
* with a 32-bit checksum and a lookup table.
*/
@SuppressWarnings("innerassignment")
abstract class CrcIntTable implements ChecksumByteBuffer {
/** Current CRC value with bit-flipped. */
private int crc;
Expand Down Expand Up @@ -98,14 +99,21 @@ private static int update(int crc, ByteBuffer b, int[] table) {

// loop unroll - duff's device style
switch (b.remaining()) {
case 7: crc = (crc >>> 8) ^ table[((crc ^ b.get()) & 0xff)];
case 6: crc = (crc >>> 8) ^ table[((crc ^ b.get()) & 0xff)];
case 5: crc = (crc >>> 8) ^ table[((crc ^ b.get()) & 0xff)];
case 4: crc = (crc >>> 8) ^ table[((crc ^ b.get()) & 0xff)];
case 3: crc = (crc >>> 8) ^ table[((crc ^ b.get()) & 0xff)];
case 2: crc = (crc >>> 8) ^ table[((crc ^ b.get()) & 0xff)];
case 1: crc = (crc >>> 8) ^ table[((crc ^ b.get()) & 0xff)];
default: // noop
case 7:
crc = (crc >>> 8) ^ table[((crc ^ b.get()) & 0xff)];
case 6:
crc = (crc >>> 8) ^ table[((crc ^ b.get()) & 0xff)];
case 5:
crc = (crc >>> 8) ^ table[((crc ^ b.get()) & 0xff)];
case 4:
crc = (crc >>> 8) ^ table[((crc ^ b.get()) & 0xff)];
case 3:
crc = (crc >>> 8) ^ table[((crc ^ b.get()) & 0xff)];
case 2:
crc = (crc >>> 8) ^ table[((crc ^ b.get()) & 0xff)];
case 1:
crc = (crc >>> 8) ^ table[((crc ^ b.get()) & 0xff)];
default: // noop
}

return crc;
Expand Down