Skip to content

Conversation

@vivekratnavel
Copy link
Contributor

Fix these checkstyle issues

hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/common/ChecksumByteBuffer.java
84: Inner assignments should be avoided.
85: Inner assignments should be avoided.
101: 'case' child has incorrect indentation level 8, expected level should be 6.
102: 'case' child has incorrect indentation level 8, expected level should be 6.
103: 'case' child has incorrect indentation level 8, expected level should be 6.
104: 'case' child has incorrect indentation level 8, expected level should be 6.
105: 'case' child has incorrect indentation level 8, expected level should be 6.
106: 'case' child has incorrect indentation level 8, expected level should be 6.
107: 'case' child has incorrect indentation level 8, expected level should be 6.
108: 'case' child has incorrect indentation level 8, expected level should be 6.

@vivekratnavel
Copy link
Contributor Author

/label ozone

@vivekratnavel
Copy link
Contributor Author

cc @bharatviswa504

@elek elek added the ozone label Oct 4, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 41 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
-1 mvninstall 36 hadoop-hdds in trunk failed.
-1 mvninstall 38 hadoop-ozone in trunk failed.
-1 compile 22 hadoop-hdds in trunk failed.
-1 compile 15 hadoop-ozone in trunk failed.
+1 checkstyle 62 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 1074 branch has no errors when building and testing our client artifacts.
-1 javadoc 21 hadoop-hdds in trunk failed.
-1 javadoc 20 hadoop-ozone in trunk failed.
0 spotbugs 1179 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 40 hadoop-hdds in trunk failed.
-1 findbugs 19 hadoop-ozone in trunk failed.
_ Patch Compile Tests _
-1 mvninstall 40 hadoop-hdds in the patch failed.
-1 mvninstall 39 hadoop-ozone in the patch failed.
-1 compile 23 hadoop-hdds in the patch failed.
-1 compile 17 hadoop-ozone in the patch failed.
-1 javac 23 hadoop-hdds in the patch failed.
-1 javac 17 hadoop-ozone in the patch failed.
+1 checkstyle 34 hadoop-hdds: The patch generated 0 new + 0 unchanged - 10 fixed = 0 total (was 10)
+1 checkstyle 33 The patch passed checkstyle in hadoop-ozone
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 993 patch has no errors when building and testing our client artifacts.
-1 javadoc 24 hadoop-hdds in the patch failed.
-1 javadoc 19 hadoop-ozone in the patch failed.
-1 findbugs 36 hadoop-hdds in the patch failed.
-1 findbugs 20 hadoop-ozone in the patch failed.
_ Other Tests _
-1 unit 27 hadoop-hdds in the patch failed.
-1 unit 26 hadoop-ozone in the patch failed.
+1 asflicense 35 The patch does not generate ASF License warnings.
2893
Subsystem Report/Notes
Docker Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1603/1/artifact/out/Dockerfile
GITHUB PR #1603
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 6f442b317358 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / a3cf54c
Default Java 1.8.0_222
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1603/1/artifact/out/branch-mvninstall-hadoop-hdds.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1603/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1603/1/artifact/out/branch-compile-hadoop-hdds.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1603/1/artifact/out/branch-compile-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1603/1/artifact/out/branch-javadoc-hadoop-hdds.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1603/1/artifact/out/branch-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1603/1/artifact/out/branch-findbugs-hadoop-hdds.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1603/1/artifact/out/branch-findbugs-hadoop-ozone.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1603/1/artifact/out/patch-mvninstall-hadoop-hdds.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1603/1/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1603/1/artifact/out/patch-compile-hadoop-hdds.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1603/1/artifact/out/patch-compile-hadoop-ozone.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1603/1/artifact/out/patch-compile-hadoop-hdds.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1603/1/artifact/out/patch-compile-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1603/1/artifact/out/patch-javadoc-hadoop-hdds.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1603/1/artifact/out/patch-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1603/1/artifact/out/patch-findbugs-hadoop-hdds.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1603/1/artifact/out/patch-findbugs-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1603/1/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1603/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1603/1/testReport/
Max. process+thread count 306 (vs. ulimit of 5500)
modules C: hadoop-hdds/common U: hadoop-hdds/common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1603/1/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@bharatviswa504 bharatviswa504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.
As CI has no checkstyle issues, I will commit this.
Thank You @vivekratnavel for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants