Skip to content

Enable tests for page index filtering in parquet filter pushdown test #4062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Enable tests for page index filtering in parquet filter pushdown test #4062

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 27 additions & 26 deletions datafusion/core/tests/parquet_filter_pushdown.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,32 +341,33 @@ impl<'a> TestCase<'a> {

assert_eq!(no_pushdown, pushdown_and_reordering);

// page index filtering is not correct:
// https://github.com/apache/arrow-datafusion/issues/4002
// when it is fixed we can add these tests too

// let page_index_only = self
// .read_with_options(
// ParquetScanOptions {
// pushdown_filters: false,
// reorder_filters: false,
// enable_page_index: true,
// },
// )
// .await;
//assert_eq!(no_pushdown, page_index_only);

// let pushdown_reordering_and_page_index = self
// .read_with_options(
// ParquetScanOptions {
// pushdown_filters: false,
// reorder_filters: false,
// enable_page_index: true,
// },
// )
// .await;

//assert_eq!(no_pushdown, pushdown_reordering_and_page_index);
let page_index_only = self
.read_with_options(
ParquetScanOptions {
pushdown_filters: false,
reorder_filters: false,
enable_page_index: true,
},
// pushdown is off so no pushdown is expected
PushdownExpected::None,
filter,
)
.await;
assert_eq!(no_pushdown, page_index_only);

let pushdown_reordering_and_page_index = self
.read_with_options(
ParquetScanOptions {
pushdown_filters: true,
reorder_filters: true,
enable_page_index: true,
},
self.pushdown_expected,
filter,
)
.await;

assert_eq!(no_pushdown, pushdown_reordering_and_page_index);
}

/// Reads data from a test parquet file using the specified scan options
Expand Down