Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Nov 1, 2022

Draft waiting on

Which issue does this PR close?

Re #3834 and #4002

Rationale for this change

Add additional test coverage for page index filtering

What changes are included in this PR?

Enable tests for page filtering in parquet filter pushdown test

Are there any user-facing changes?

No

@alamb
Copy link
Contributor Author

alamb commented Nov 4, 2022

I have updated this PR to add tests for page filtering. However, I would like to wait for @Ted-Jiang 's statistics PR to land first and add some additional verification to this PR prior to merging #4105

@alamb alamb force-pushed the alamb/test_issue_3838 branch from 1de7b45 to d77d71c Compare November 7, 2022 14:43
@alamb alamb marked this pull request as ready for review November 7, 2022 14:43
@alamb alamb requested review from Ted-Jiang and tustvold November 7, 2022 14:43
@alamb alamb changed the title Enable tests for page filtering in parquet filter pushdown test Enable tests for page index filtering in parquet filter pushdown test Nov 7, 2022
@alamb alamb merged commit 532b4a7 into apache:master Nov 7, 2022
@alamb alamb deleted the alamb/test_issue_3838 branch November 7, 2022 19:48
@ursabot
Copy link

ursabot commented Nov 7, 2022

Benchmark runs are scheduled for baseline = 6b71294 and contender = 532b4a7. 532b4a7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@Ted-Jiang
Copy link
Member

@alamb Thanks! let's see what going on 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants